Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State orchestration bugs resolved #706

Merged
merged 5 commits into from
Feb 28, 2023
Merged

State orchestration bugs resolved #706

merged 5 commits into from
Feb 28, 2023

Conversation

jonathanalvares9009
Copy link
Collaborator

Reference

Add reference to a related issue that this pull request is addressing. For example, fixes #

Describe the pull request

Please describe the changes proposed in this pull request.
This PR intends to solve some bugs in the state machine:

  • If the user selected a component and then clicked outside a canvas zone the component was still selected. The correct behaviour would be to transition into Ready.Idle.
  • If a component gets deleted the overlay wasn't removed as the parent was undefined due to deletion of the component.

Contributors (in case of a commit with multiple authors)

Co-authors:

@cruxcode cruxcode merged commit 9e63a86 into Atri-Labs:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants