Adding a dictionary to avoid multiple condition checks and improve code quality. #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello there! Welcome to the project! 💖 Thanks for opening your very first pull request here! ✨ We will get back to you as soon as we can. Besides, don’t forget to ⭐ the repository, if you haven’t already! |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
N/A
Describe the pull request
Currently the file is checking for OS to generate a 'system_str'. It is going through the 3 if statements.
If the condition is true for the first one, it will still check for the latter two conditions as the if statements are independent. The process is repeated a several times.
A quick fix to improve the loop would be using 'elif' instead of multiple 'if' statements. But even in that case, we would be experiencing unnecessary looping 66% of the times. A better fix would be using a dictionary. I have added a dictionary to generate the 'system_str' in this PR.
Contributors (in case of a commit with multiple authors)
Co-authors: