-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AppImage CI build #1005
Add AppImage CI build #1005
Conversation
The CI needs changed to be built against Ubuntu 22.04 rather than the latest as to ensure compatibility. |
After messing around I found two minor things : |
Apparently the artifact clears the executable bit? This also seems to be happening to the dynamic build. Neither launch.sh nor the executable really come in as with x bit set, despite them being set in the CI. |
The CI latest image has burnt us before with Mac |
I already set the Linux CI to |
Any final objections here? @stonedDiscord @TrickyLeifa |
Does the appimage work? |
Works fine on my end. There are still some aspects that I can work out later, though, like how it doesn't seem to have an icon, or how |
Tested and the executable bit is set properly. |
Ah, I should say, icons only work if you have I think most desktop environments have a default icon for AppImages though. At least KDE does, from when I used it. |
zip files don't support the executable bit, you'd have to put it in a tar file before to keep the bit. |
What it says on the tin.
Requires #1003 so that paths in the AppImage are resolved correctly.