Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppImage CI build #1005

Merged
merged 8 commits into from
Jul 7, 2024
Merged

Conversation

lambdcalculus
Copy link
Contributor

What it says on the tin.

Requires #1003 so that paths in the AppImage are resolved correctly.

@lambdcalculus lambdcalculus requested a review from TrickyLeifa July 5, 2024 18:12
@TrickyLeifa
Copy link
Contributor

The CI needs changed to be built against Ubuntu 22.04 rather than the latest as to ensure compatibility.

@Salanto
Copy link
Contributor

Salanto commented Jul 6, 2024

After messing around I found two minor things :
The AppImage does not have an application icon and that its missing the execution bit on Linux, so people need to either chmod it or use the file property dialog. I think just adding the bit to the appimage before zipping should be enough to make it portable.
Otherwise works on anything never than 22.04 LTS (without updates) since it links to a GLibC that is not present on 20.04 LTS

@lambdcalculus
Copy link
Contributor Author

Apparently the artifact clears the executable bit? This also seems to be happening to the dynamic build. Neither launch.sh nor the executable really come in as with x bit set, despite them being set in the CI.

This was linked to issues Jul 6, 2024
@stonedDiscord
Copy link
Member

The CI latest image has burnt us before with Mac
Can you be more specific about the version

@lambdcalculus
Copy link
Contributor Author

I already set the Linux CI to ubuntu-22.04. I kept the formatting check on ubuntu-latest, since it doesn't really matter, so that might be what you saw.

@Salanto
Copy link
Contributor

Salanto commented Jul 7, 2024

Any final objections here? @stonedDiscord @TrickyLeifa

@stonedDiscord
Copy link
Member

Does the appimage work?

@lambdcalculus
Copy link
Contributor Author

Works fine on my end. There are still some aspects that I can work out later, though, like how it doesn't seem to have an icon, or how appimagetool complains about a lack of update information when making the AppImage. But this is good for a start I think.

@Salanto
Copy link
Contributor

Salanto commented Jul 7, 2024

Tested and the executable bit is set properly.

@Salanto Salanto merged commit f91be6b into AttorneyOnline:master Jul 7, 2024
3 checks passed
@lambdcalculus
Copy link
Contributor Author

The AppImage does not have an application icon

Ah, I should say, icons only work if you have appimaged and configure it appropriately, I believe.

I think most desktop environments have a default icon for AppImages though. At least KDE does, from when I used it.

@stonedDiscord
Copy link
Member

Apparently the artifact clears the executable bit? This also seems to be happening to the dynamic build. Neither launch.sh nor the executable really come in as with x bit set, despite them being set in the CI.

zip files don't support the executable bit, you'd have to put it in a tar file before to keep the bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt 6.5 as the only supported Qt version AppImage distribution
4 participants