Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evidence system, improve evidence user experience #660

Merged
merged 3 commits into from
Feb 21, 2022
Merged

Conversation

Crystalwarrior
Copy link
Contributor

@Crystalwarrior Crystalwarrior commented Feb 18, 2022

Polish up the evidence system so it's a single-click editing
Fix evidence editing changes caused by #587
Fix issues with "ok" button detecting itself as "changes from the server"
Fix "ok" button remaining after you press it once, allowing you to spam evidence update packets by spamclicking it

Fix evidence editing regressions caused by #587
Fix issues with "ok" button detecting itself as "changes from the server"
Fix "ok" button remaining after you press it once, allowing you to spam evidence update packets by spamclicking it
Copy link
Member

@in1tiate in1tiate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me, I wasn't particularly attached to the way I did it in #587.

I wouldn't exactly call it a regression, though...?

@Crystalwarrior
Copy link
Contributor Author

I wouldn't exactly call it a regression, though...?

Hmm, I guess you're right that it's not a regression since it did not go back to old behavior pre-changes

@Crystalwarrior Crystalwarrior changed the title Fix evidence system regressions, improve evidence user experience Fix evidence system, improve evidence user experience Feb 18, 2022
@oldmud0 oldmud0 merged commit b5908ad into master Feb 21, 2022
@in1tiate in1tiate deleted the fix-evidence branch July 18, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants