Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showname and selfname colors to courtroom_fonts.ini #672

Merged
merged 6 commits into from
Mar 19, 2022

Conversation

Crystalwarrior
Copy link
Contributor

@Crystalwarrior Crystalwarrior commented Feb 22, 2022

Cyan = selfname, light gray = other name
image

image

To implement, in courtroom_fonts.ini:

ic_chatlog_selfname_color = 0, 255, 255
ic_chatlog_showname_color = 200, 200, 200

Closes #671
Also overhauls chatlogpiece.cpp and chatlogpiece.h slightly
TODO: a settings option to ignore selfname

@Crystalwarrior
Copy link
Contributor Author

if anyone can make a settings option for me that'd be amazing <3

Copy link
Member

@oldmud0 oldmud0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok. Just a lot of boilerplate I guess.

include/chatlogpiece.h Outdated Show resolved Hide resolved
src/courtroom.cpp Outdated Show resolved Hide resolved
Crystalwarrior and others added 3 commits February 23, 2022 05:55
Co-authored-by: oldmud0 <oldmud0@users.noreply.github.com>
Co-authored-by: oldmud0 <oldmud0@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/chatlogpiece.h Outdated Show resolved Hide resolved
include/chatlogpiece.h Outdated Show resolved Hide resolved
src/courtroom.cpp Show resolved Hide resolved
Crystalwarrior and others added 2 commits March 13, 2022 17:40
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/chatlogpiece.h Show resolved Hide resolved
@Crystalwarrior Crystalwarrior requested a review from oldmud0 March 13, 2022 15:50
Copy link
Member

@oldmud0 oldmud0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add ic_chatlog_selfname_color, ic_chatlog_showname_color to courtroom_fonts for the default theme, even if we're not actually changing the colors

src/courtroom.cpp Show resolved Hide resolved
@oldmud0 oldmud0 merged commit 35fcbde into master Mar 19, 2022
@in1tiate in1tiate deleted the log-selfname-color branch July 18, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: different colored IC name on own message
2 participants