-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Objections no longer force you into preanimations #697
Conversation
Fix preanim zoom not toggling the checkbox from char.ini, but deprecated "4" doing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
clang-tidy review says "All clean, LGTM! 👍" |
Huh, what? I know I fixed this already. When did this sneak back in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based enum
Honestly no clue |
Finally, you can use the Objection shout without being forced into preanim, allowing you to have control what sprite you'll use once objection is over - idle or pre.
This is backwards compatible with every client prior as well due to how arbitrary this "force pre when objecting" thing was lol
Fixes #692
Also fixes preanim zoom emote mod (6) not getting its pre checkbox getting ticked on, forcing char.ini makers to use the deprecated emote mod (4)