Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objections no longer force you into preanimations #697

Merged
merged 5 commits into from
Mar 25, 2022

Conversation

Crystalwarrior
Copy link
Contributor

@Crystalwarrior Crystalwarrior commented Mar 24, 2022

Finally, you can use the Objection shout without being forced into preanim, allowing you to have control what sprite you'll use once objection is over - idle or pre.

This is backwards compatible with every client prior as well due to how arbitrary this "force pre when objecting" thing was lol

Fixes #692
Also fixes preanim zoom emote mod (6) not getting its pre checkbox getting ticked on, forcing char.ini makers to use the deprecated emote mod (4)

@Crystalwarrior Crystalwarrior added this to the 2.10 milestone Mar 24, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/emotes.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@in1tiate
Copy link
Member

Huh, what? I know I fixed this already. When did this sneak back in?

Copy link
Member

@stonedDiscord stonedDiscord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based enum

@Crystalwarrior
Copy link
Contributor Author

Huh, what? I know I fixed this already. When did this sneak back in?

Honestly no clue

@Crystalwarrior Crystalwarrior merged commit ca83573 into master Mar 25, 2022
@in1tiate in1tiate deleted the objection-respect-pre branch July 18, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objections should respect preanim checkbox
3 participants