Rework MS list callback logic #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes crash when joining server before getting ms list back
in1tiate
approved these changes
Nov 28, 2023
stonedDiscord
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the callback pattern from
get_server_listandms_request_finishedsince the only callback ever used in these was listing the servers anyhow.Also fixes a segfault that happened when joining a server before the MS list was acquired (AO would try to have lobby list the servers while lobby didn't exist, after getting a reply for the MS list).
Technically to fix this crash only an if check around the callback was required, so if removing the callback pattern is too much I can have the pull request do only the check ¯\_(ツ)_/¯ (accessing lobby from the network manager IS kind of ugly).
edit: fix shrug emoji (important)