This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
[PAY-244][PAY-245] Update tip modal header and extract pill button #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sddioulde
force-pushed
the
sd-modal-icon-pill-button
branch
from
2add00d to
ff3278a
Compare
rickyrombo
reviewed
Jul 27, 2022
| @@ -0,0 +1,42 @@ | |||
| .button { | |||
| height: unset !important; | |||
There was a problem hiding this comment.
Using !important is very bad smell, are there other ways we could accomplish this? 😨
dylanjeffers
approved these changes
Jul 27, 2022
packages/web/src/components/tipping/tip-audio/TipAudioModal.tsx
Outdated
Show resolved
Hide resolved
sddioulde
changed the title
sddioulde
force-pushed
the
sd-modal-icon-pill-button
branch
from
830f327 to
a2db179
Compare
sddioulde
force-pushed
the
sd-modal-icon-pill-button
branch
from
a2db179 to
8447c57
Compare
sddioulde
force-pushed
the
sd-modal-icon-pill-button
branch
from
8c3086b to
2a99164
Compare
This was referenced Jul 28, 2022
Closed
audius-infra
pushed a commit
that referenced
this pull request
Jul 30, 2022
[293e8a4] [C-737] Update eslint and prettier setup (#1663) Kyle Shanks [0ceab71] bump libs to 0.0.22 (#1662) nicoback2 [11855a2] Update artist popover profile picture skeleton to be round (#1660) Kyle Shanks [4114a2d] Move services from web/common to @audius/common (#1633) nicoback2 [8d60d9f] Add rollup-plugin-dts and sync bn.js versions (#1658) Sebastian Klingler [28ff1f5] Consume stems 1.1.14 in web (#1657) Saliou Diallo [8525bde] [PAY-244][PAY-245] Update tip modal header and extract pill button (#1653) Saliou Diallo [81a5524] Move types from `web/common` to `@audius/common` (#1618) nicoback2 [c75a5c3] Small update to the styling of user searchbar result skeletons (#1652) Kyle Shanks [d3db729] fix oauth user ids - client side (#1557) nicoback2 [4f4eef2] [PAY-390] Improve tipping notification types (#1521) Dylan Jeffers [21cc889] [C-721] Fix notifications not loading past 20 (#1648) Dylan Jeffers [63e4bcb] [C-710] Update the skeletons for the UserCard and the search bar results (#1647) Kyle Shanks [39b2ab5] [C-584] Add others link to web notifications (#1646) Dylan Jeffers [41fc93e] [C-709] Fix native audio tier (#1645) Dylan Jeffers [3ca632f] [C-708] Fix the table styles for sorted columns for dark mode and matrix mode (#1644) Kyle Shanks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update stems components:
The new PillButton can be used for future components. It takes a type prop that will change the hover and active state styles accordingly (currently only primary and secondary types).
Dragons
n/a
How Has This Been Tested?
local against stage
=============
How will this change be monitored?
n/a
Feature Flags
none