[PLAT-538] Enable redis persistence #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just something to note: "...if the dataset is big, and may result in Redis stopping serving clients for some milliseconds or even for one second if the dataset is very big and the CPU performance is not great. " |
our dataset is 400mb and also it says that it may pause for milliseconds or maybe a second at worst. I think ok! the write only append ahead is another option but I think not warranted |
stereosteve
added a commit
that referenced
this pull request
Jan 24, 2023
* Add comms container * proper comms docker repo * wip-comms for now * [PLAT-538] Enable redis persistence * volume for NATS * Add chain health check * add block production to chain health check * Configure NATS_STORE_DIR * Add redis restart * separate nats container * add comms containers to creator node docker compose * comms depends on nats * [PLAT-538] Enable redis persistence (#176) Comment copy change * Launch chain on prod (#184) * add chain to upgrade * remove sync logs * add no recreate Co-authored-by: Raymond Jacobson <ray@audius.co> Co-authored-by: Isaac Solo <isaac@audius.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Snapshot every 60 seconds so long as there has been 1 write.
This should be performant and far better than our custom persistence (especially on discovery) which persists every redis write for some keys to a file
https://redis.io/docs/management/persistence/
Adds
restart: alwaysto redis because rdb backups will let us recoup redis state if it crashes.