Clean up artist_pick_track_id in APIUser (#3381)

AudiusProject · May 18, 2023 · 81da65e · 81da65e
1 parent 64d89ef
commit 81da65e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/packages/common/src/services/audius-api-client/ResponseAdapter.ts b/packages/common/src/services/audius-api-client/ResponseAdapter.ts
@@ -38,14 +38,9 @@ export const makeUser = (
     return undefined
   }
 
-  // TODO remove conditional once all DNs are encoding the artist pick ID
-  let decoded_artist_pick_track_id: number | null
-  if (typeof user.artist_pick_track_id === 'string') {
-    decoded_artist_pick_track_id = decodeHashId(user.artist_pick_track_id)
-  } else {
-    decoded_artist_pick_track_id = user.artist_pick_track_id
-  }
-
+  const decoded_artist_pick_track_id = user.artist_pick_track_id
+    ? decodeHashId(user.artist_pick_track_id)
+    : null
   const balance = user.balance as StringWei
   const associated_wallets_balance =
     user.associated_wallets_balance as StringWei

diff --git a/packages/common/src/services/audius-api-client/types.ts b/packages/common/src/services/audius-api-client/types.ts
@@ -23,8 +23,7 @@ export type OpaqueID = string
 
 export type APIUser = {
   album_count: number
-  // TODO remove number type once all DNs are encoding the artist pick ID
-  artist_pick_track_id: Nullable<number | OpaqueID>
+  artist_pick_track_id: Nullable<OpaqueID>
   blocknumber: number
   balance: string
   associated_wallets_balance: string