Upgrade sentry and enhance it to better detect upload failures (#8809)

AudiusProject · Jun 13, 2024 · cd29fc1 · cd29fc1
1 parent 53d4622
commit cd29fc1
Show file tree

Hide file tree

Showing 5 changed files with 139 additions and 101 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/web/package.json b/packages/web/package.json
@@ -98,9 +98,8 @@
     "@radix-ui/react-slot": "1.0.2",
     "@react-spring/web": "9.7.2",
     "@reduxjs/toolkit": "1.6.1",
-    "@sentry/browser": "7.65.0",
+    "@sentry/browser": "7.117.0",
     "@sentry/cli": "2.31.2",
-    "@sentry/integrations": "7.65.0",
     "@solana/spl-token": "0.3.8",
     "@solana/web3.js": "1.78.4",
     "@stripe/crypto": "0.0.4",

diff --git a/packages/web/src/common/store/upload/sagas.test.ts b/packages/web/src/common/store/upload/sagas.test.ts
@@ -270,7 +270,7 @@ describe('upload', () => {
         ])
         // Reports to sentry
         .call(reportToSentry, {
-          name: 'Upload: Error',
+          name: 'Upload Worker Failed: Error',
           error: mockError,
           additionalInfo: {
             trackId: 3,
@@ -289,7 +289,7 @@ describe('upload', () => {
           fn: reportToSentry,
           args: [
             {
-              name: 'Upload: Error',
+              name: 'Upload Worker Failed: Error',
               additionalInfo: {
                 trackId: 1,
                 metadata: testTrack.metadata,

diff --git a/packages/web/src/common/store/upload/sagas.ts b/packages/web/src/common/store/upload/sagas.ts
@@ -601,7 +601,9 @@ export function* handleUploads({
           trackIndex,
           stemIndex: null,
           trackId: tracks[trackIndex].metadata.track_id,
-          error: new Error('Stem failed to upload.'),
+          error: new Error(`Stem ${stemIndex} failed to upload.`, {
+            cause: payload.error
+          }),
           phase
         }
       })
@@ -617,7 +619,7 @@ export function* handleUploads({
     // Report to sentry
     const e = error instanceof Error ? error : new Error(String(error))
     yield* call(reportToSentry, {
-      name: `Upload: ${e.name}`,
+      name: `Upload Worker Failed: ${e.name}`,
       error: e,
       additionalInfo: {
         trackId,
@@ -698,7 +700,9 @@ export function* handleUploads({
     }
     // Errors were reported to sentry earlier in the upload process.
     // Throwing here so callers don't think they succeeded.
-    throw new Error('Failed to upload tracks for collection.')
+    throw new Error('Failed to upload tracks for collection.', {
+      cause: errored
+    })
   }
 
   const publishedTrackIds = published
@@ -710,7 +714,7 @@ export function* handleUploads({
   if (publishedTrackIds.length === 0) {
     // Errors were reported to sentry earlier in the upload process.
     // Throwing here so callers don't think they succeeded.
-    throw new Error('No tracks were successfully uploaded.')
+    throw new Error('No tracks were successfully uploaded.', { cause: errored })
   }
 
   console.debug('Finished uploads')

diff --git a/packages/web/src/services/sentry.ts b/packages/web/src/services/sentry.ts
@@ -1,5 +1,4 @@
-import { init } from '@sentry/browser'
-import { CaptureConsole } from '@sentry/integrations'
+import * as Sentry from '@sentry/browser'
 
 import { env } from './env'
 
@@ -15,20 +14,23 @@ const analyticsBlacklist = [
 const MAX_BREADCRUMBS = 300
 
 export const initializeSentry = () => {
-  init({
+  Sentry.init({
     dsn: env.SENTRY_DSN,
+    transport: Sentry.makeBrowserOfflineTransport(Sentry.makeFetchTransport),
     ignoreErrors:
       process.env.VITE_SENTRY_DISABLED === 'true' ? [/.*/] : undefined,
 
     // Need to give Sentry a version so it can
     // associate stacktraces with sourcemaps
     release: process.env.VITE_CURRENT_GIT_SHA,
 
-    // Capture console.errors in sentry
     integrations: [
-      new CaptureConsole({
-        levels: ['error']
-      })
+      // Pull extra fields off error objects
+      Sentry.extraErrorDataIntegration(),
+      // Catch failed network requests
+      Sentry.httpClientIntegration(),
+      // Capture console.errors in sentry
+      Sentry.captureConsoleIntegration({ levels: ['error'] })
     ],
 
     normalizeDepth: 5,
@@ -43,7 +45,7 @@ export const initializeSentry = () => {
       }
       // filter out analytics events
       if (hint && hint.xhr) {
-        const url = hint.xhr.__sentry_xhr__.url
+        const url = hint.xhr.__sentry_xhr_v3__.url
         const isAnalyticsRequest = analyticsBlacklist.some(
           (term) => url.search(term) !== -1
         )