Skip to content

Commit

Permalink
[C-2472] Update mobile track list items for playlists to have the ove…
Browse files Browse the repository at this point in the history
…rflow menu (#3577)
  • Loading branch information
Kyle-Shanks authored Jun 13, 2023
1 parent 51f44ac commit fbd4053
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 2 deletions.
3 changes: 2 additions & 1 deletion packages/mobile/src/components/track-list/TrackListItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ const useStyles = makeStyles(({ palette, spacing, typography }) => ({
iconContainer: {
marginLeft: spacing(2)
},
icon: { height: 16, width: 16 },
icon: { height: 20, width: 20 },
removeIcon: { height: 24, width: 24 },

playButtonContainer: {
Expand Down Expand Up @@ -431,6 +431,7 @@ const TrackListItemComponent = (props: TrackListItemComponentProps) => {
{trackItemAction === 'overflow' ? (
<IconButton
icon={IconKebabHorizontal}
fill={themeColors.neutralLight4}
styles={{
root: styles.iconContainer,
icon: styles.icon
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ export const CollectionScreenDetailsTile = ({
const renderTrackList = useCallback(() => {
return (
<TrackList
trackItemAction='overflow'
showDivider
showSkeleton={isLineupLoading}
togglePlay={handlePressTrackListItemPlay}
Expand Down
18 changes: 17 additions & 1 deletion packages/web/src/components/table/Table.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
border-radius: 8px;
box-shadow: 0 2px 5px -2px var(--tile-shadow-3);
background-color: var(--white);
padding-top: 24px;
overflow: hidden;
}

Expand All @@ -23,6 +22,7 @@
.tableHead {
position: relative;
display: block;
padding-top: 24px;
background-color: var(--white);
color: var(--neutral);
font-size: 14px;
Expand All @@ -47,6 +47,7 @@
position: relative;
flex: 0 0 144px;
}

.cellSectionEnd.menu {
flex: 0 0 64px;
}
Expand All @@ -59,9 +60,11 @@
line-height: 41px;
user-select: none;
}

.tableHeader.hasSorter .textCell {
padding-right: 6px;
}

.titleHeader + .titleHeader::before {
content: '';
position: absolute;
Expand Down Expand Up @@ -114,9 +117,11 @@
color: var(--neutral-light-2);
cursor: pointer;
}

.pageButton:not(.active):hover {
color: var(--neutral);
}

.pageButton.active {
background-color: var(--secondary);
color: var(--static-white);
Expand All @@ -129,15 +134,19 @@
margin: 0 8px;
cursor: pointer;
}

.pageCaret path {
fill: var(--neutral-light-4);
}

.pageCaret:not(.disabled):hover path {
fill: var(--neutral);
}

.pageCaret.disabled {
cursor: default;
}

.pageCaret.disabled path {
fill: var(--neutral-light-7);
}
Expand All @@ -152,9 +161,11 @@
border-top: 1px solid var(--neutral-light-8);
cursor: pointer;
}

.showMoreContainer:hover .showMoreText {
color: var(--neutral);
}

.showMoreContainer:hover .showMoreCaret path {
fill: var(--neutral);
}
Expand All @@ -170,6 +181,7 @@
height: 16px;
width: 16px;
}

.showMoreCaret path {
transition: all 0.07s ease-in-out;
fill: var(--neutral-light-4);
Expand All @@ -191,21 +203,25 @@
font-weight: 600;
cursor: pointer;
}

.tableRow.active {
color: var(--primary);
}

.tableRow:hover:not(.skeletonRow) {
z-index: 1;
box-shadow: 0 1px 0 0 var(--neutral-light-8),
0 -1px 0 0 var(--neutral-light-8);
transition: all 0.07s ease-in-out;
background-color: var(--neutral-light-9);
}

.tableRow.disabled {
cursor: default;
color: var(--neutral-light-4);
background-color: var(--neutral-light-9);
}

.tableRow.disabled:hover {
box-shadow: none;
background-color: var(--neutral-light-9);
Expand Down

0 comments on commit fbd4053

Please sign in to comment.