[ASI-756] PR #4 - primary sync from secondary #2303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidSethi
changed the title
SidSethi
changed the title
SidSethi
commented
Jan 19, 2022
creator-node/scripts/run-tests.sh
Outdated
| @@ -53,7 +53,7 @@ run_unit_tests () { | |||
|
|
|||
| run_integration_tests () { | |||
| echo Running integration tests... | |||
| ./node_modules/mocha/bin/mocha test/*.test.js --timeout "${INTEGRATION_TIMEOUT}" --exit | |||
| ./node_modules/mocha/bin/mocha test/nodesync.test.js --timeout "${INTEGRATION_TIMEOUT}" --exit | |||
There was a problem hiding this comment.
TODO revert full file changes
SidSethi
commented
Jan 19, 2022
| @@ -106,6 +106,7 @@ async function processSync( | |||
| timeout: 300000 /* 5m = 300000ms */ | |||
| }) | |||
|
|
|||
| // SIDNOTE - zero instances of this log on prod 14 days | |||
There was a problem hiding this comment.
TODO remove underlying code
SidSethi
commented
Jan 31, 2022
| @@ -0,0 +1,47 @@ | |||
| /** | |||
There was a problem hiding this comment.
copied from processSync.js with very slight modifications:
- rename
redisKeytologPrefix - wrpa in try-catch
SidSethi
force-pushed
the
ss-files-hash-bugfix-v2
branch
from
9490bd2 to
f69e157
Compare
SidSethi
force-pushed
the
ss-primary-should-sync-e2e
branch
from
c6924b1 to
6b68a46
Compare
|
closing in favor of #3399 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests
How will this change be monitored?