[PAY-172] Add monitoring for reactions #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piazzatron
changed the title
piazzatron
force-pushed
the
piazz-reactions-monitoring
branch
from
927b5bd to
02656fb
Compare
rickyrombo
approved these changes
May 17, 2022
| @@ -1,7 +1,8 @@ | |||
| import logging | |||
| import os | |||
| import time | |||
| from datetime import datetime | |||
| from datetime import date, datetime | |||
| from optparse import Option | |||
| indexing_delta and max_indexing_drift and indexing_delta > max_indexing_drift | ||
| ) | ||
| is_unhealthy_reaction = bool( | ||
| reaction_delta and max_reaction_drift and reaction_delta > max_reaction_drift |
There was a problem hiding this comment.
Not sure how useful this one will be for determining overall health, since it's possible nobody reacts. I see it's an optional param for now though but still curious if it needs to be part of the overall is_healthy calculation?
There was a problem hiding this comment.
I was thinking you can set it super conservatively - like if nobody reacts in 2 days or something. Without something like this, the indexing check alone won't catch if there's a logic error somewhere later in that function that processes the reactions. Wdyt
There was a problem hiding this comment.
My biggest concern would be a spiralling reselection and degraded user experience because nobody reacted for a while, but as long as we don't include the argument in libs and keep it optional, I'm ok with it
There was a problem hiding this comment.
Good thought - would definitely only include this for our monitoring system
piazzatron
added a commit
that referenced
this pull request
May 17, 2022
sliptype
pushed a commit
that referenced
this pull request
Sep 10, 2023
[a82b6d2] [C-2391 PLAT-833] Handle get-discovery-notification error, notification processing (#3141) Dylan Jeffers [b6a8470] [PAY-1073] Mobile messages settings screen (#3131) Reed [c567b35] Separate chat text input to own component (#3142) Reed [1a38cb1] [PAY-1090] - Subscribe to special access gates to unlock new tracks (#3108) Saliou Diallo [9e5a45d] Set dev optimizely key (#3126) Sebastian Klingler [c5e86fa] [PLAT-699] Add tastemaker notification to web (#3140) Dylan Jeffers [4bc608c] [C-2295] Only show now-playing-artwork-tile when song enqueued (#3137) Dylan Jeffers [aa34b32] [PAY-1039] Mobile chat header navs to profile (#3139) Reed [55f5819] Optimizely attributes - use null if empty instead of undefined (#3134) nicoback2 [92ab79e] [C-2387] Improve permalink and user handle caching (#3117) Dylan Jeffers [086af81] [PAY-1107][PAY-1112] Center mobile chat text input, enlarge icon (#3136) Reed [fcec3f5] [PAY-1123] Fix mobile chat scroll being stuck (#3135) Reed [a276e86] Revert "Allow Optimizely targeting w CodePush on mobile C-2394" (#3133) nicoback2 [3335b4a] [C-2357] Update the icon color of the podcast skip buttons to accept the theme color (#3132) Kyle Shanks [1af5730] Fix dapp store versionCode (#3121) Dylan Jeffers [7787115] Fix app store version fetched from Apple in Fastlane being out of date first 24h after new release C-2397 (#3128) nicoback2 [06c181d] Allow Optimizely targeting w CodePush on mobile C-2394 (#3127) nicoback2 [ff07c32] [PAY-1038] Fix mobile profile page button borders (#3130) Reed [9286959] [PAY-1027] Mobile chat websockets (#3129) Reed [81ef3b3] [PAY-1031] Mobile chat list views use full height (#3123) Reed [41e3f5d] [C-2231] Remove audius-data, dynamically import web3modal (#1771) Raymond Jacobson [34d80be] [PAY-1111] Remove "Done" row on ios keyboard for mobile chats (#3124) Reed [9eb83a8] [PAY-1102] - Add supporters info drawer (#3112) Saliou Diallo [6fe7abe] Add dependencies, bundle to mobile README (#3111) Reed [dc8d4f2] Show header shadow in chat screens (#3106) Reed [f871a38] [PAY-906] Mobile chats KeyboardAvoidingView (#3122) Reed [fd00bf2] Fix chat reactions with createEntityAdapter (#3118) Reed [9876137] Switch to 1s (#3120) Raymond Jacobson [fe9efea] Tip using both erc_wallet and wallet (#3049) Michael Piazza [fdfc0b6] Update dapp store readme (#3119) Raymond Jacobson [ca58e69] [C-2359, C-2380] Update duration text for podcast tiles (#3116) Kyle Shanks [6441421] [PLAT-695] Add trending notifications to valid_types (#3109) Dylan Jeffers [4233ee6] [PAY-1083] - Only allow prompt modal when single track is being uploaded (#3115) Saliou Diallo [36909d1] Always include user signature for stream (#3114) Raymond Jacobson [b90eaf6] [C-2386] Fix notification button not toggling panel (#3110) Dylan Jeffers [a3c2e91] Check if messagesStatus undefined in ChatScreen (#3113) Reed [64d89ca] [C-2382] Update dapp-store cli, short_description length (#3104) Dylan Jeffers [680931d] [C-2361, C-2360, C-2355, C-2346] Update skip 15s button behavior on mobile for podcasts (#3105) Kyle Shanks [3eb742f] [C-2353, C-2358] Update playback position tracking for web and mobile (#3097) Kyle Shanks [e06c4d9] Bump sdk to 2.0.3-beta.1 (#3098) Isaac Solo [8191694] Fix "Pick some for me" button on android (#3102) Sebastian Klingler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new params and data to healthcheck for reactions
Tests
Tested locally
How will this change be monitored? Are there sufficient logs?