[CON-103] - Enable cid cache #3519

vicky-g · 2022-07-20T19:05:43Z

Description

This PR is to default the cache to be cache to be enabled on all nodes in the application layer. To get this working, we also need to re-order how the env files are created for Content Nodes, by first loading in commonEnv.sh, and then the shellEnv<n>.sh files.

Tests

Ran the local stack, with cn1 having the cache enabled, and the rest of the cns defaulted disabled in the commonEnv.sh file -> works
Ran the local stack, with all of the cns defaulted disabled in the commonEnv.sh file -> works

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

See the X-Cache-Status header in /ipfs/<cid>, /content/<cid> routes. There should be a HIT or MISS as the value

…-cid-cache

dmanjunath

this changes look fine to me, lets wait for CI to fully pass before merging. also tagging @cheran-senthil just in case this changes anything with local docker compose setup.

## Changelog - 2022-07-21 [6db3974] Sanity check setIsCreatorToTrue (#3531) [Sid Sethi] - 2022-07-21 [4af6a34] Revert Revert [PLAT-254] Remove is_creator usage across protocol (#3475) (#3529) (#3530) [Dylan Jeffers] - 2022-07-21 [6311d71] Revert [PLAT-254] Remove is_creator usage across protocol (#3475) (#3529) [Dylan Jeffers] - 2022-07-21 [e91d0ef] [PAY-455] SDK: Convert TransactionHandler to TypeScript and export on core (#3515) [Marcus Pasell] - 2022-07-21 [17c9130] [CON-233] Add queue history for all remaining queues (#3524) [Johannes Naylor] - 2022-07-21 [9ce2208] More state machine cleanup (#3522) [Theo Ilie] - 2022-07-20 [2fad6f0] [CON-262] Add more test coverage for /export (#3520) [Johannes Naylor] - 2022-07-20 [15006a2] [CON-243] - Use prometheus middleware package to track route duration (#3494) [vicky :)] - 2022-07-20 [43e43fe] Increase write quorum timeout to 1m (#3521) [Theo Ilie] - 2022-07-20 [914bfa3] [CON-103] - Enable cid cache (#3519) [vicky :)] - 2022-07-20 [338f8eb] Clean up misc state machine (#3518) [Theo Ilie] - 2022-07-20 [bfc6505] [C-587] Verify sdk types in ci (#3495) [Sebastian Klingler] - 2022-07-19 [af2e650] [C-688] Move docs over to monorepo (#3504) [Raymond Jacobson] - 2022-07-19 [c993992] CON-258 Modify findSyncRequest.jobProcessor with more detailed metrics (#3478) [Sid Sethi] - 2022-07-19 [afe0b61] Fix primarySyncFromSecondary circular dep by moving initAudiusLibs to separate file (#3507) [Sid Sethi]

[a16abc2] Revert force mobile full staging build (#3564) nicoback2 [27f0a1b] [PAY-1386] DMs: Mark chat as read on client when new message from self comes through websocket (#3562) Marcus Pasell [ab41a52] Force mobile build again (#3561) nicoback2 [ac383dc] DMs: Fix broken messages (#3559) Marcus Pasell [29b49ee] Force mobile staging build - Android (#3560) nicoback2 [57ff5c5] Force mobile staging build (#3558) nicoback2 [5456271] Update plist to 1.1.66 (#3557) Marcus Pasell [48c70b1] [PAY-1398] Fix ChatUserListScreen scrolling with keyboard (#3552) Reed [ba19c1d] [PAY-1423] Fix empty chat message box with currently playing track (#3553) Reed [970224f] Mobile ChatMessageListItem uses message id + selector (#3551) Reed [49ff351] [PAY-1426] DMs: Simplify unfurl styles for mobile, fix border radius shadow (#3555) Marcus Pasell [63faad0] [PAY-1403] Fix chat track unfurl reactions (#3550) Reed [a8e92b7] [PAY-1425][PAY-1424] DMs: Fix image unfurls, fix purple halo around unfurls (#3554) Marcus Pasell [940aebe] [PAY-1367][PAY-1400][PAY-1401][PAY-1402][PAY-1419] Fix chat tile unfurl bugs (#3541) Saliou Diallo [61b6735] [PAY-1378] Cap image size on mobile DMs (#3548) Reed [a495c35] [PAY-1409] DMs: Deep link into chat from notification (#3549) Marcus Pasell [a4e6426] [PAY-1393] DMs: Hide message underneath popover (#3547) Marcus Pasell [a6711f1] [C-2691] Carry values through the form fields (#3539) Andrew Mendelsohn [d653f5c] [C-2747] Fix track title layout with offline + ai attribution (#3546) Andrew Mendelsohn [8e54ff7] [PAY-1408][PAY-1351][PAY-1383][PAY-1417][PAY-1240][PAY-1345] DMs: Web UI polishes and bugfixes (#3543) Marcus Pasell [cc1bc46] [C-2746] Fix favorites album tab styling (#3544) Kyle Shanks [1dbb753] [PAY-1406][PAY-1374][PAY-1353][PAY-1411] Fix DMs UI Issues (#3542) Michael Piazza [b76eef2] [PAY-1348] clean up ChatUserListScreen and use followers as default list (#3538) Randy Schott [3ed58ac] DMs: Wait for tip confirmation then refetch permissions (#3537) Marcus Pasell [bb4f317] [PAY-1366] Fix web chat tile artwork and mobile link preview bugs (#3528) Saliou Diallo [ea47ecf] DMs: Fix deletions not causing perms rechecks (#3540) Marcus Pasell [0b8c993] [PAY-1356] Mobile chats scroll to bottom when re-entering chat screen (#3536) Reed [52f7b94] [PAY-1363] DMs: Add CTA to Create Chat user rows (#3530) Marcus Pasell [4c22b12] [C-2461, C-2476] Prevent user from dragging hidden tracks to public playlists (#3535) Kyle Shanks [f2ad1ce] [C-1873, C-2551, C-2552, C-2553] Add hidden track logic for playlists on web (#3529) Kyle Shanks [083b0ff] [PAY-1315] Fix mobile chat search screen takes 2 presses (#3534) Reed [da64d93] [PAY-1347] DMs: Don't show unread indicator for first messages (#3532) Marcus Pasell [7ae88cb] [PAY-1394] DMs: Show global unread indicator if there's unread messages in a loaded chat (#3533) Marcus Pasell [40abf58] [PAY-1350] Update send button styling on web (#3523) Michael Piazza [cd1e238] [PAY-1149] Mobile chat reactions add android offset (#3531) Reed [3595ce8] [PAY-1362] Mobile press chat message closes reaction popup (#3527) Reed [06d10e2] [PAY-1361] Fix reactions button hit area (#3524) Michael Piazza [e97ed82] [PAY-1309] Use proper tracking of hasMore for chats list (#3517) Randy Schott [fe72398] [PAY-1365] Disable fullscreen gestures on mobile chat screen (#3526) Reed [03cbcac] [PAY-1392] Mobile mark chat as read onscroll, on navigate away (#3522) Reed [e6af9d7] [PAY-919][PAY-1312] Chat track and playlist tiles on mobile (#3455) Saliou Diallo [e2896fe] [C-2719] Clean up and document non v1 usage (#3520) Raymond Jacobson [2cf5bb7] Add reason to account slice, handle fetch account failure with sentry (#3525) Raymond Jacobson [4451447] [PAY-1342][PAY-1360] DMs: Show users as chat unlocked by default, optimistic chat navigation (#3514) Marcus Pasell [8262221] [PAY-1391] ensure all collections are fetched before attempting to download (#3521) Randy Schott [e29d35f] [PAY-1385] Mobile chat send icon updates (#3516) Reed [8cda7b2] [PAY-1390] fix inverted condition for computing track count (#3519) Randy Schott [3a3b206] [PAY-1333] Mobile dms end of history only shows with >10 messages (#3515) Reed [f1f5dc0] [PAY-1370] Fix reaction touch targets (#3513) Reed [9b81487] Upgrade sdk to 2.0.3-beta.36 (#3512) Dylan Jeffers [b48777a] Remove content node cid query route (#3408) Michelle Brier [69e5656] [C-2717] Fix playlist create tile bug (#3510) Kyle Shanks [828015f] Remove yield* in js files (#3511) Sebastian Klingler [7d26233] Add mobile hidden track playlist logic (#3505) Kyle Shanks [cf9c5d5] [PAY-1137][PAY-1132] Infinite loading of albums on mobile favorites screen (#3398) Randy Schott

vicky-g added 4 commits July 15, 2022 22:39

expose trusted notifier data in health check + tests

4563a81

default enabled cache

57d4519

Merge branch 'master', remote-tracking branch 'origin' into vg-enable…

671bd3f

…-cid-cache

switch order in loading up commonenv before custom shell env

8abb6d6

pull-request-size bot added the size/M label Jul 20, 2022

vicky-g requested a review from dmanjunath July 20, 2022 19:09

vicky-g assigned SidSethi Jul 20, 2022

dmanjunath approved these changes Jul 20, 2022

View reviewed changes

dmanjunath requested a review from cheran-senthil July 20, 2022 19:13

cheran-senthil approved these changes Jul 20, 2022

View reviewed changes

vicky-g merged commit 914bfa3 into master Jul 20, 2022

vicky-g deleted the vg-enable-cid-cache branch July 20, 2022 19:50

sliptype pushed a commit that referenced this pull request Sep 10, 2023

[PAY-1390] fix inverted condition for computing track count (#3519)

f4cf519

AudiusProject deleted a comment from linear bot Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CON-103] - Enable cid cache #3519

[CON-103] - Enable cid cache #3519

vicky-g commented Jul 20, 2022 •

edited

Loading

dmanjunath left a comment

[CON-103] - Enable cid cache #3519

[CON-103] - Enable cid cache #3519

Conversation

vicky-g commented Jul 20, 2022 • edited Loading

Description

Tests

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

dmanjunath left a comment

Choose a reason for hiding this comment

vicky-g commented Jul 20, 2022 •

edited

Loading