Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor _score in to script_score script #3556

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

stereosteve
Copy link
Contributor

Description

In a script_score you have to actually factor in _score if you want it to behave like field_value_factor

Tests

Ran search_quality script thusly:

    A up
    docker exec -it dn1_web-server_1 bash
    PYTHONPATH=. python3 scripts/search_quality.py

Confirmed results look correct.

@stereosteve stereosteve merged commit b91aa19 into master Jul 27, 2022
@stereosteve stereosteve deleted the fix_es_script_score branch July 27, 2022 19:15
audius-infra pushed a commit that referenced this pull request Jul 27, 2022
## Changelog

- 2022-07-27 [bca55d5] Dont set the nginx cache in the application layer (#3561) [Dheeraj Manjunath]
- 2022-07-27 [5d147c5] Bump to version 0.3.63 (#3559) [Cheran]
- 2022-07-27 [d0cb450] Unpin Python to fix discovery build (#3558) [Cheran]
- 2022-07-27 [b91aa19] Factor _score in to script_score script (#3556) [Steve Perkins]
- 2022-07-27 [36dcb1b] [CON-201] Remove QueueInterfacer + increase RS update concurrency (#3554) [Theo Ilie]
- 2022-07-27 [f9ac2dd] [CON-283] Add upload success metrics (#3546) [Johannes Naylor]
- 2022-07-26 [6f4ee64] [CON-281] - Add CNodeToSpIdMapManager init in stateMachineManager init (#3553) [vicky :)]
- 2022-07-26 [57560fb] [CON-294] Make manual sync queue less backed up (#3549) [Theo Ilie]
- 2022-07-26 [87c4f2c] Log cnode to sp id map when determining replica set updates (#3550) [vicky :)]
- 2022-07-26 [bd76c8e] Fix diffing (#3548) [Sebastian Klingler]
- 2022-07-23 [5b31feb] Add container-side pidfile for celery (#3544) [Raymond Jacobson]
- 2022-07-23 [bf82366] State machine - split queues and fix many bugs (#3539) [Theo Ilie]
- 2022-07-22 [8a1b901] Fix prometheus metrics name error (#3543) [Johannes Naylor]
- 2022-07-22 [0bec2b4] Add prometheus metrics for `secondarySyncFromPrimary` (#3532) [Johannes Naylor]
- 2022-07-22 [8dfd837] Fix bucketing fn + variable name change (#3534) [vicky :)]
- 2022-07-22 [0b895ab] Add force_export query param to /export route for MergePrimaryAndSecondary (#3541) [Sid Sethi]
- 2022-07-22 [0e5d0dc] Skip bad notifs (#3540) [Saliou Diallo]
- 2022-07-22 [5a007c3] CN - Fix export bug (#3537) [Sid Sethi]
- 2022-07-22 [1050286] [CON-265] Add percentage based metrics to network monitoring (#3525) [Johannes Naylor]
- 2022-07-22 [1ea1dbb] [PAY-433] Fixed Ray's broken prod account (#3523) [Reed]
- 2022-07-22 [9048086] Only track metrics for explicit routes (#3527) [vicky :)]
- 2022-07-22 [bc0256a] Add error msg to a write quorum error flow (#3535) [vicky :)]
audius-infra pushed a commit that referenced this pull request Jul 27, 2022
## Changelog

- 2022-07-27 [ad5188c] CircleCI GCP image bake env var was undefined (#3562) [Dheeraj Manjunath]
- 2022-07-27 [bca55d5] Dont set the nginx cache in the application layer (#3561) [Dheeraj Manjunath]
- 2022-07-27 [5d147c5] Bump to version 0.3.63 (#3559) [Cheran]
- 2022-07-27 [d0cb450] Unpin Python to fix discovery build (#3558) [Cheran]
- 2022-07-27 [b91aa19] Factor _score in to script_score script (#3556) [Steve Perkins]
- 2022-07-27 [36dcb1b] [CON-201] Remove QueueInterfacer + increase RS update concurrency (#3554) [Theo Ilie]
- 2022-07-27 [f9ac2dd] [CON-283] Add upload success metrics (#3546) [Johannes Naylor]
- 2022-07-26 [6f4ee64] [CON-281] - Add CNodeToSpIdMapManager init in stateMachineManager init (#3553) [vicky :)]
- 2022-07-26 [57560fb] [CON-294] Make manual sync queue less backed up (#3549) [Theo Ilie]
- 2022-07-26 [87c4f2c] Log cnode to sp id map when determining replica set updates (#3550) [vicky :)]
- 2022-07-26 [bd76c8e] Fix diffing (#3548) [Sebastian Klingler]
- 2022-07-23 [5b31feb] Add container-side pidfile for celery (#3544) [Raymond Jacobson]
- 2022-07-23 [bf82366] State machine - split queues and fix many bugs (#3539) [Theo Ilie]
- 2022-07-22 [8a1b901] Fix prometheus metrics name error (#3543) [Johannes Naylor]
- 2022-07-22 [0bec2b4] Add prometheus metrics for `secondarySyncFromPrimary` (#3532) [Johannes Naylor]
- 2022-07-22 [8dfd837] Fix bucketing fn + variable name change (#3534) [vicky :)]
- 2022-07-22 [0b895ab] Add force_export query param to /export route for MergePrimaryAndSecondary (#3541) [Sid Sethi]
- 2022-07-22 [0e5d0dc] Skip bad notifs (#3540) [Saliou Diallo]
- 2022-07-22 [5a007c3] CN - Fix export bug (#3537) [Sid Sethi]
- 2022-07-22 [1050286] [CON-265] Add percentage based metrics to network monitoring (#3525) [Johannes Naylor]
- 2022-07-22 [1ea1dbb] [PAY-433] Fixed Ray's broken prod account (#3523) [Reed]
- 2022-07-22 [9048086] Only track metrics for explicit routes (#3527) [vicky :)]
- 2022-07-22 [bc0256a] Add error msg to a write quorum error flow (#3535) [vicky :)]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants