Fix entity manager playlist invalidation #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsolo
force-pushed
the
is-revert-false-current
branch
from
1ed3f57 to
ee0f807
Compare
isaacsolo
force-pushed
the
is-revert-false-current
branch
from
ee0f807 to
a7a21c5
Compare
raymondjacobson
approved these changes
Aug 25, 2022
isaacsolo
added a commit
that referenced
this pull request
Aug 25, 2022
audius-infra
pushed a commit
that referenced
this pull request
Aug 31, 2022
## Changelog - 2022-08-30 [b2033d5] [C-927] Fix 0x prefix in native (#3788) [Raymond Jacobson] - 2022-08-30 [287f5e2] Temporarily remove track repost and save prevention for premium tracks in indexing (#3792) [Saliou Diallo] - 2022-08-30 [843c8c9] Enable reconfigs for one secondary by default (#3794) [Theo Ilie] - 2022-08-30 [3060080] Fix incomplete replica set for deregistered node (#3791) [Theo Ilie] - 2022-08-30 [d8cb6a1] fix n+1 query bug in model_to_dictionary (#3793) [Steve Perkins] - 2022-08-30 [e386114] Regenerate package lock in eth contracts (#3790) [Cheran] - 2022-08-30 [0e27048] Final fixes for E2E local compose (#3789) [Cheran] - 2022-08-30 [ed12c45] [CON-284] Add tracing decorator and decorate non-queue functions (#3750) [Johannes Naylor] - 2022-08-29 [4c46521] PrimarySyncFromSecondary log nit (#3787) [Sid Sethi] - 2022-08-29 [ac33e4d] [PAY-481][PAY-483][PAY-484] Add premium content write changes to DN (#3752) [Saliou Diallo] - 2022-08-29 [e4d1af9] CON-371 PrimarySyncFromSecondary Rewrite for Perf Improvements (#3759) [Sid Sethi] - 2022-08-29 [6f10439] CON-370 Fix export bug for large users (#3779) [Sid Sethi] - 2022-08-29 [9a20f2f] Fix orphaned data gte and log stack for reconfig 500s (#3786) [Theo Ilie] - 2022-08-29 [d905e1d] Fix last_added_to field for uploaded collections (#3784) [Isaac Solo] - 2022-08-29 [e240525] [INF-181] Add audius-cmd (#3612) [Cheran] - 2022-08-29 [5327ff5] Add syncForceWipeEnabled env var (#3778) [Theo Ilie] - 2022-08-26 [a81235a] Gracefully stop recover-orphaned-data jobs (#3776) [Theo Ilie] - 2022-08-26 [de178d2] EntityManager Upgradeability Unit Test (#3740) [Hareesh Nagaraj] - 2022-08-26 [3b98f10] v1.0.0 (#3777) [Reed] - 2022-08-26 [5129552] Fix failing test-solana-programs-anchor CI (#3775) [Isaac Solo] - 2022-08-26 [179e41d] Add logs to orphaned data recovery job (#3774) [Theo Ilie] - 2022-08-26 [aad5c9f] INF-227 Finalize additional Grafana Alerting entities (#3732) [Joaquin Casares] - 2022-08-26 [5eaec3e] Remove rsyslogd from identity (#3769) [Dheeraj Manjunath] - 2022-08-26 [0a5ecbb] Fix bug in fetching sync export + consolidate logic (#3771) [Theo Ilie] - 2022-08-26 [cba01d4] Make orphaned data fixes + improvements (#3766) [Theo Ilie] - 2022-08-25 [28cccc7] [PAY-586] Rename getAssociatedTokenAccountInfo and getUserBank (#3762) [Reed] - 2022-08-25 [432caa7] Add storage path size prometheus metric in content node (#3768) [Dheeraj Manjunath] - 2022-08-25 [c5dde7d] New "soft unhealthy" env var + actually set healthy status from content node (#3730) [Dheeraj Manjunath] - 2022-08-25 [2ae731d] Fix issueSyncRequest libs not having ethContracts (#3764) [Theo Ilie] - 2022-08-25 [0b4d837] CON-368 Fix sync duration logging bug #3763 [Sid Sethi] - 2022-08-25 [fe85228] Fix wormhole with upgraded libs (#3757) [Raymond Jacobson] - 2022-08-25 [33c9973] Fix invalidate playlist's original record (#3761) [Isaac Solo] - 2022-08-25 [732a1d4] Skip replica set updates for users w/o URSM data (#3754) [Theo Ilie] - 2022-08-25 [75ab7b5] Make Content Node tsconfig include all src files (#3760) [Theo Ilie] - 2022-08-25 [18d1af4] [CON-324] Implement orphaned data recovery (#3696) [Theo Ilie] - 2022-08-25 [e74f72b] CON-366 CN - Log on secondarySyncFromPrimary() success + logging cleanup (#3749) [Sid Sethi] - 2022-08-25 [2389d8f] Bump sdk to v0.0.40 [audius-infra] - 2022-08-24 [9133cab] Fix entity manager playlist invalidation (#3756) [Isaac Solo] - 2022-08-24 [a680ad2] Fix last added and invalid tx (#3755) [Isaac Solo]
audius-infra
pushed a commit
that referenced
this pull request
Aug 31, 2022
## Changelog - 2022-08-30 [b2033d5] [C-927] Fix 0x prefix in native (#3788) [Raymond Jacobson] - 2022-08-30 [287f5e2] Temporarily remove track repost and save prevention for premium tracks in indexing (#3792) [Saliou Diallo] - 2022-08-30 [843c8c9] Enable reconfigs for one secondary by default (#3794) [Theo Ilie] - 2022-08-30 [3060080] Fix incomplete replica set for deregistered node (#3791) [Theo Ilie] - 2022-08-30 [d8cb6a1] fix n+1 query bug in model_to_dictionary (#3793) [Steve Perkins] - 2022-08-30 [e386114] Regenerate package lock in eth contracts (#3790) [Cheran] - 2022-08-30 [0e27048] Final fixes for E2E local compose (#3789) [Cheran] - 2022-08-30 [ed12c45] [CON-284] Add tracing decorator and decorate non-queue functions (#3750) [Johannes Naylor] - 2022-08-29 [4c46521] PrimarySyncFromSecondary log nit (#3787) [Sid Sethi] - 2022-08-29 [ac33e4d] [PAY-481][PAY-483][PAY-484] Add premium content write changes to DN (#3752) [Saliou Diallo] - 2022-08-29 [e4d1af9] CON-371 PrimarySyncFromSecondary Rewrite for Perf Improvements (#3759) [Sid Sethi] - 2022-08-29 [6f10439] CON-370 Fix export bug for large users (#3779) [Sid Sethi] - 2022-08-29 [9a20f2f] Fix orphaned data gte and log stack for reconfig 500s (#3786) [Theo Ilie] - 2022-08-29 [d905e1d] Fix last_added_to field for uploaded collections (#3784) [Isaac Solo] - 2022-08-29 [e240525] [INF-181] Add audius-cmd (#3612) [Cheran] - 2022-08-29 [5327ff5] Add syncForceWipeEnabled env var (#3778) [Theo Ilie] - 2022-08-26 [a81235a] Gracefully stop recover-orphaned-data jobs (#3776) [Theo Ilie] - 2022-08-26 [de178d2] EntityManager Upgradeability Unit Test (#3740) [Hareesh Nagaraj] - 2022-08-26 [3b98f10] v1.0.0 (#3777) [Reed] - 2022-08-26 [5129552] Fix failing test-solana-programs-anchor CI (#3775) [Isaac Solo] - 2022-08-26 [179e41d] Add logs to orphaned data recovery job (#3774) [Theo Ilie] - 2022-08-26 [aad5c9f] INF-227 Finalize additional Grafana Alerting entities (#3732) [Joaquin Casares] - 2022-08-26 [5eaec3e] Remove rsyslogd from identity (#3769) [Dheeraj Manjunath] - 2022-08-26 [0a5ecbb] Fix bug in fetching sync export + consolidate logic (#3771) [Theo Ilie] - 2022-08-26 [cba01d4] Make orphaned data fixes + improvements (#3766) [Theo Ilie] - 2022-08-25 [28cccc7] [PAY-586] Rename getAssociatedTokenAccountInfo and getUserBank (#3762) [Reed] - 2022-08-25 [432caa7] Add storage path size prometheus metric in content node (#3768) [Dheeraj Manjunath] - 2022-08-25 [c5dde7d] New "soft unhealthy" env var + actually set healthy status from content node (#3730) [Dheeraj Manjunath] - 2022-08-25 [2ae731d] Fix issueSyncRequest libs not having ethContracts (#3764) [Theo Ilie] - 2022-08-25 [0b4d837] CON-368 Fix sync duration logging bug #3763 [Sid Sethi] - 2022-08-25 [fe85228] Fix wormhole with upgraded libs (#3757) [Raymond Jacobson] - 2022-08-25 [33c9973] Fix invalidate playlist's original record (#3761) [Isaac Solo] - 2022-08-25 [732a1d4] Skip replica set updates for users w/o URSM data (#3754) [Theo Ilie] - 2022-08-25 [75ab7b5] Make Content Node tsconfig include all src files (#3760) [Theo Ilie] - 2022-08-25 [18d1af4] [CON-324] Implement orphaned data recovery (#3696) [Theo Ilie] - 2022-08-25 [e74f72b] CON-366 CN - Log on secondarySyncFromPrimary() success + logging cleanup (#3749) [Sid Sethi] - 2022-08-25 [2389d8f] Bump sdk to v0.0.40 [audius-infra] - 2022-08-24 [9133cab] Fix entity manager playlist invalidation (#3756) [Isaac Solo] - 2022-08-24 [a680ad2] Fix last added and invalid tx (#3755) [Isaac Solo]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Invalidate existing playlist only if there's an updated record. The change below removed the invalidating for the existing playlist and assumed the existing_playlist would be in new_records. This adds a lookup of the existing record and updates it.
#3755
Tests
Tested locally.
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?