Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C-3139] Add create password page #6186

Merged
merged 3 commits into from
Oct 2, 2023
Merged

[C-3139] Add create password page #6186

merged 3 commits into from
Oct 2, 2023

Conversation

dylanjeffers
Copy link
Contributor

Description

Implements bare-bones create-password page for sign up redesign
Adds tests for all envs

@dylanjeffers dylanjeffers requested review from a team and nicoback2 and removed request for a team September 29, 2023 22:29
@audius-infra
Copy link
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/dj-c-3139-password-page

amendelsohn
amendelsohn approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@amendelsohn amendelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great to have a skeleton laid out

packages/mobile/src/screens/root-screen/RootScreen.tsx Outdated
@@ -115,7 +115,7 @@ export const RootScreen = () => {
/>
) : showHomeStack ? (
<Stack.Screen name='HomeStack' component={AppDrawerScreen} />
) : isSignUpRedesignEnabled ? (
) : !isSignUpRedesignEnabled ? (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for testing or an intended change?

packages/web/src/pages/sign-up-page/pages/CreatePasswordPage.tsx
return (
<div>
<h1>{messages.header}</h1>
<p>{messages.description}</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Text> everywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes soon :) we are just about to have the harmony text component ready

@dylanjeffers dylanjeffers merged commit e254d74 into main Oct 2, 2023
2 checks passed
@dylanjeffers dylanjeffers deleted the dj-c-3139-password-page branch October 2, 2023 18:36
schottra added a commit that referenced this pull request Oct 2, 2023
@schottra
Merge remote-tracking branch 'origin/main' into pay-1860-mobile-pay-e…
2685a32 
…xtra-2

* origin/main:
  @audius/sdk: v3.0.11-beta.4
  [C-3168] Add missing submit type on button (#6194)
  [C-3139] Add create password page (#6186)
  @audius/sdk: v3.0.11-beta.3
  multiple peer providers with fallback behavior (#6192)
  @audius/sdk: v3.0.11-beta.2
  PROTO-1299: scroll uploads for backfill (#6180)
  @audius/sdk: v3.0.11-beta.1
audius-infra pushed a commit that referenced this pull request Oct 7, 2023
v1.5.45
7c00f48 
[948683a] Fix gasPrice bug (#6271) Marcus Pasell
[0ccf190] Revert "Revert "[PLAT-259] Upgrade EthereumTx version (#3606)" (#3682)" (#6269) Marcus Pasell
[b6ef1bc] Add react-query to mobile (#6267) Sebastian Klingler
[0754f6a] fix package-lock.json (#6263) Steve Perkins
[dfef5c7] Fix offline collections not loading if started offline (#6245) nicoback2
[8765cb7] Make createAssociatedTokenAccount idempotent for root wallet (#6266) Marcus Pasell
[f8c839a] More web+mobile UI for $AUDIO matching challenges (#6265) Reed
[bbd4cd8] [C-3175] Replace instances of HarmonySelectablePill in web with harmony component (#6246) Kyle Shanks
[1542421] [PAY-1974] Fix explore premium tracks bugs (#6237) Saliou Diallo
[6149349] Backfill challenges amount migration (#6262) Reed
[a9d1a97] trpc: social modal shows list of users who did X (#6253) Steve Perkins
[f732050] [PROTO-1320] Run CI jobs without GCP (#6218) Danny
[6bdf3d4] [PAY-1960] Clean up withdrawals decimal places (#6260) Raymond Jacobson
[36a7802] Bump version to 0.4.25 audius-infra
[28f3e68] [PAY-1975] Fix withdrawal email decimals (#6261) Raymond Jacobson
[eaf3dfe] Wire up UI for $AUDIO matching challenges (#6255) Reed
[ce1c9a9] [C-3174] Add select genre page to sign up (#6241) Dylan Jeffers
[b233a8c] [C-3181, C-3182] Fix collection loading, drawer closing, feature flag perf (#6254) Dylan Jeffers
[ca7f8ee] [C-3133] Port HarmonyButton to harmony package (#6242) Andrew Mendelsohn
[3d294fd] Remove sdk autopublish (#6259) Sebastian Klingler
[cfb519d] bump DN dockerfile python3 dependency to 3.11.6 (#6257) Michelle Brier
[faa348d] @audius/sdk: v3.0.11-beta.21 audius-infra
[949a60d] Remove partition migration again (#6226) Michelle Brier
[a955572] @audius/sdk: v3.0.11-beta.20 audius-infra
[82b278b] Rename access log file (#6256) Isaac Solo
[93a539c] Fix identity push (#6247) Sebastian Klingler
[7c5c10c] rm unneeded error log (#6252) Alec Savvy
[22f2161] [PAY-1945] Add column for amount in user_challenges table + backfill (#6212) Reed
[23c687e] @audius/sdk: v3.0.11-beta.19 audius-infra
[c4862d5] Remove dead code (#6251) Raymond Jacobson
[ca860eb] @audius/sdk: v3.0.11-beta.18 audius-infra
[4f25b11] Remove anon v1 full trending tracks cache (#6250) Isaac Solo
[48a38ff] @audius/sdk: v3.0.11-beta.17 audius-infra
[6fbf250] Add request time in json to server logs (#6235) Isaac Solo
[00921fa] @audius/sdk: v3.0.11-beta.16 audius-infra
[d90c993] Remove broken ethgasstation.info usage, let default gas be set (#6248) Marcus Pasell
[7d021fa] [PAY-1956] Add pay extra column to purchases and sales csv (#6234) Saliou Diallo
[55bea71] @audius/sdk: v3.0.11-beta.15 audius-infra
[7b7586b] [C-3176] Update harmony css variables and import harmony styles into web and embed (#6240) Kyle Shanks
[71b0ae1] @audius/sdk: v3.0.11-beta.14 audius-infra
[139221f] Bump version to 0.4.24 audius-infra
[525f895] @audius/sdk: v3.0.11-beta.13 audius-infra
[b9a71cb] [PROTO-1317] Fix sitemap counts (#6244) Raymond Jacobson
[c9f38bb] @audius/sdk: v3.0.11-beta.12 audius-infra
[931f8c5] [PAY-1944] Bring back AudioBreakdown (#6243) Raymond Jacobson
[97782eb] @audius/sdk: v3.0.11-beta.11 audius-infra
[2e17d03] Always pass test-discovery-api  (#6238) Isaac Solo
[0db1f4b] @audius/sdk: v3.0.11-beta.10 audius-infra
[c360cdb] Update harmony tsconfig to allow for css module classnames without errors (#6236) Kyle Shanks
[fa3c013] @audius/sdk: v3.0.11-beta.9 audius-infra
[b75f5b9] [C-3165] Add finish-account sign-up page (#6196) Dylan Jeffers
[51221e1] Add vercel context for dist jobs (#6233) Sebastian Klingler
[55c2ef7] @audius/sdk: v3.0.11-beta.8 audius-infra
[35c39fb] [PROTO-1239] Fix initting ClaimsManagerClient (#6232) Theo Ilie
[5a450e6] @audius/sdk: v3.0.11-beta.7 audius-infra
[0c510dc] [PAY-1934] Fix some issues with purchase modal state (#6231) Randy Schott
[93cac56] [PAY-1875] Add Premium Tracks Explore Page - Part 1 (#6202) Saliou Diallo
[3b77629] Bump app version to trigger full app release (#6230) nicoback2
[7c03b3c] FollowsYouChip uses trpc (#6227) Steve Perkins
[3207650] @audius/sdk: v3.0.11-beta.6 audius-infra
[14a3b80] [PAY-1903] Default minimum purchase to 1.00 (#6225) Raymond Jacobson
[c25a197] @audius/sdk: v3.0.11-beta.5 audius-infra
[09b6ea0] Fix coming soon tag (#6224) Raymond Jacobson
[c6a90c4] [INF-500] Fix libs tests (#6228) Sebastian Klingler
[9d46861] [INF-501] Disable mobile prod builds on main (#6229) Sebastian Klingler
[1b09f0f] Defer jimp.min.js (#6223) Raymond Jacobson
[f8c1d05] [C-3134] Add SelectablePill component to harmony (#6214) Kyle Shanks
[c4226fe] Bump version to 0.4.23 audius-infra
[889a911] Fix several USDC purchase related bugs (#6222) Raymond Jacobson
[df75ad9] PROTO-1287/1286: add relay reselection logic and relay to healthz (#6140) Alec Savvy
[e0c8f62] As/minor bot fixes (#6221) Alec Savvy
[3fa6a97] PAY-1507, PAY-1769: USDC Withdrawals: SOL Swapping for Uninitiated Accounts (#6220) Marcus Pasell
[558182b] Fix flaky follows on sign up, mobile C-2718 (#6219) nicoback2
[98f6820] Revert "Import harmony styles in web and embed (#6191)" (#6217) Raymond Jacobson
[0de7821] Remove erroneous local-storage (#6216) Raymond Jacobson
[e5901a7] verified bot follow ons (#6215) Alec Savvy
[505b3b0] [PAY-1838] Implement coming soon option for usdc gate (#6189) Raymond Jacobson
[00015d8] Import harmony styles in web and embed (#6191) Kyle Shanks
[fabf67c] PROTO-1304: fix uploads bot (#6206) Alec Savvy
[4181c36] [C-3171] Add Icons to Harmony (#6213) Kyle Shanks
[9f7cf0c] [PAY-1861] Expose Pay Extra details in purchase/sales tables (#6209) Randy Schott
[d90897f] [PAY-1927] Cleanup redux state on purchase modal close (#6210) Reed
[181a6ae] fix import order (#6211) Steve Perkins
[ddf5cb5] Sp es triggers (#6207) Steve Perkins
[786f7a8] [PAY-1936] Allow preview timestamps to be set for "unpreviewable" tracks (#6200) Raymond Jacobson
[1cd4f15] tRPC build + push docker image (#6204) Steve Perkins
[261fb90] [PAY-1939] Convert purchase content drawer to full screen variant (#6205) Randy Schott
[cbcac0f] [PAY-1860] Implements Pay Extra form on mobile (#6184) Randy Schott
[a7fccae] [PROTO-1297] Persist storage/db sizes in db + crudr (#6177) Theo Ilie
[d74e905] [PROTO-1293] Reverse proxy to healthz from mediorum server (#6193) Danny
[2c7e3a0] Optimize trending requests (#6199) Isaac Solo
[f77bf15] [INF-499] Update paths for uploading prober artifacts (#6197) Sebastian Klingler
[127217e] Bump version to 0.4.22 audius-infra
[38525ef] Readall when serving image. (#6201) Steve Perkins
[1362f0e] [PAY-1884] Audio matching challenges for buyer and seller (#6175) Reed
[40325c8] [PAY-1917] Add parens around seconds (#6198) Raymond Jacobson
[15a283d] FollowsYou badge uses trpc (#6195) Steve Perkins
[e72f9ae] [INF-479] [INF-494] Move identity to packages, improve audius-compose dev performance (#6160) Sebastian Klingler
[f04ca8f] @audius/sdk: v3.0.11-beta.4 audius-infra
[6186d98] [C-3168] Add missing submit type on button (#6194) Andrew Mendelsohn
[e254d74] [C-3139] Add create password page (#6186) Dylan Jeffers
[50f9e28] @audius/sdk: v3.0.11-beta.3 audius-infra
[a64b4d8] multiple peer providers with fallback behavior (#6192) Steve Perkins
[a479f4b] @audius/sdk: v3.0.11-beta.2 audius-infra
[a6d1b1f] PROTO-1299: scroll uploads for backfill (#6180) Steve Perkins
[b35c3ea] @audius/sdk: v3.0.11-beta.1 audius-infra
[be5c877] [PAY-1627] Fix stripe onramp layout on moweb (#6174) Raymond Jacobson
[64c899e] Bump version to 0.4.21 audius-infra
[1aa60e3] @audius/sdk: v3.0.11-beta.0 audius-infra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amendelsohn amendelsohn amendelsohn approved these changes

@nicoback2 nicoback2 Awaiting requested review from nicoback2 nicoback2 was automatically assigned from AudiusProject/client

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylanjeffers @audius-infra @amendelsohn