Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out 0-amount challenges #6488

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Filter out 0-amount challenges #6488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/web/src/common/store/pages/audio-rewards/sagas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,11 +256,13 @@ function* claimChallengeRewardAsync(
}
let aaoErrorCode
try {
const challenges = specifiers.map(({ specifier, amount }) => ({
challenge_id: challengeId,
specifier,
amount
}))
const challenges = specifiers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about mobile? Wondering if this should be done at the saga layer where we try to do the claims?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe this is the saga layer, it's just in web/common but it gets imported to mobile at the end of the day. this is the in-flight common migration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh duh, you're right. I stopped reading after packages/web. Carry on!

.map(({ specifier, amount }) => ({
challenge_id: challengeId,
specifier,
amount
}))
.filter(({ amount }) => amount > 0) // We shouldn't have any 0 amount challenges, but just in case.

const response: { error?: string; aaoErrorCode?: number } = yield* call(
audiusBackendInstance.submitAndEvaluateAttestations,
Expand Down