[C-3370] Fix harmony types #6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanjeffers
requested review from
a team,
Kyle-Shanks and
dharit-tan
and removed request for
a team
dharit-tan
reviewed
Nov 15, 2023
|
|
||
| export type IconComponent = ComponentType<IconProps> | ||
| export type IconComponent = ComponentType<BaseIconProps | IconProps> |
There was a problem hiding this comment.
i'm no ts wizard but do we need the | BaseIconProps if IconProps is already intersection'd (&) with BaseIconProps and the extra fields of IconProps are optional?
There was a problem hiding this comment.
It's a bit weird, but its for stems icons passed into harmony components. This is either the icon with some extra props (harmony icons) or just the base props (stems). Ideally this just goes away when we migrate all the icons
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
dharit-tan
approved these changes
Nov 15, 2023
|
Preview this change https://demo.audius.co/dj-c-3370-harmony-types |
Kyle-Shanks
reviewed
Nov 15, 2023
| @@ -76,8 +76,8 @@ | |||
| "rollup": "2.76.0", | |||
| "rollup-plugin-dts": "4.2.2", | |||
| "rollup-plugin-typescript2": "0.32.1", | |||
| "ttypescript": "^1.5.15", | |||
| "typescript-transform-paths": "^3.4.4" | |||
| "ttypescript": "1.5.15", | |||
There was a problem hiding this comment.
this is always going to look like a typo to me
Kyle-Shanks
approved these changes
Nov 15, 2023
audius-infra
pushed a commit
that referenced
this pull request
Nov 18, 2023
[a917c79] Fix MetaMask not working C-3386 (#6738) nicoback2 [58b4140] Implement sign up + sign in with Metamask C-3356 (#6732) nicoback2 [6956101] [PAY-2174] Support mobile web properly in add funds flows (#6740) Raymond Jacobson [cd09949] Support FixedDecimal on mobile (#6739) Marcus Pasell [cc6d1c7] [PAY-2173] Make payments page work nicely in mobile web (#6726) Raymond Jacobson [a2e38c2] [PAY-2152] Bring add funds up to spec (web) (#6725) Raymond Jacobson [48f90ca] [C-3383] Update Divider (#6728) Dylan Jeffers [170634d] [C-3237] Sign Up Mobile Nav Header (#6730) JD Francis [bcbe2d5] Tweak Harmony Icon Docs (#6733) JD Francis [c152f0e] [PAY-2158] Update purchase-content saga to account for purchase method (#6737) Randy Schott [bb4beae] Fix metamask help url (#6736) Isaac Solo [4706195] [PAY-2156] Purchase flow web ui updates (#6718) Reed [682e572] [PAY-2168] Add better typechecking for FixedDecimal (#6724) Marcus Pasell [5e8f8b7] [C-3337] Fix table section end styles (#6731) Kyle Shanks [e69bdf5] [C-3270] Mobile UI for create email page (#6701) JD Francis [6a507f5] Bump version to 0.5.19 audius-infra [47910e2] [PAY-2159] Make purchase summary collapsible on web (#6719) Randy Schott [f7162e7] [C-3364] FollowButton (#6708) Andrew Mendelsohn [d6cad0a] Update modal title and icon colors (#6721) Dylan Jeffers [9b492af] Add accent color to text and icons (#6720) Dylan Jeffers [41dc703] Upgrade wagmi to v2 (in /d) (#6712) Theo Ilie [5061bee] Rename /payandearn to /payments (#6717) Raymond Jacobson [664a1aa] Fixed package-lock.json to not have broken bn types in @audius/fixed-decimal (#6716) Marcus Pasell [c02dfb3] [C-3363] FollowArtistsPage initial layout (#6692) Andrew Mendelsohn [5e64792] [C-3378] Improve web-app hierarchy (#6710) Dylan Jeffers [bc48098] Patch verified user on creation (#6705) Isaac Solo [f0d7a57] Fix icon color/layout in summary table (#6715) Raymond Jacobson [96f418b] [PAY-2164] Update web nav usdc and audio (#6696) Saliou Diallo [ed26ea6] [C-3353] Add WelcomeModal for the new sign up flow for both web and mobile web (#6707) Kyle Shanks [026aead] [PAY-2154] Implement add funds modal (#6714) Raymond Jacobson [68aa7b5] Bump version to 0.5.18 audius-infra [c35bac5] [PROTO-1426] Display chain+GH versions with react-query (#6704) Theo Ilie [19b532c] Fix protodash mobile nav services & governance (#6709) Theo Ilie [e8ebbc6] Update docs for upload track mood (#6706) Isaac Solo [27c8aa4] [PROTO-1398] Add audius-d sandbox-compatible startup to mediorum (#6693) Danny [d584a9e] [C-3375] Update TextLink styles and examples (#6703) Dylan Jeffers [5d237e8] [PAY-2161] Implement FilterButton in Harmony (#6697) Raymond Jacobson [d6e8c15] Healthz explorer (#6664) Steve Perkins [d16b941] Fix 10th track has 15s wait bug (#6702) Reed [ca5bf83] [C-3362] Port Popup component to Harmony (#6685) Raymond Jacobson [902e805] [PROTO-1430] Add external wallets to /d (fka /up) (#6695) Theo Ilie [6947471] [C-3370] Fix harmony types (#6694) Dylan Jeffers [55f2957] Bump version to 0.5.17 audius-infra [7ec407d] [PAY-2165][PAY-2163] Add payments and earnings to mobile (#6688) Saliou Diallo [33e22f1] [C-3223] Add select-genre sign-up page (#6691) Dylan Jeffers [5302154] Sales, Purchases, Withdrawals tables on Pay & Earn Page (#6684) Reed [a5c1cf8] [C-3369] Add checkbox/radio types to SelectablePill (#6689) Dylan Jeffers [9a83de5] Migrate release_date from string to date (#6655) Isaac Solo [c7445f9] [PAY-2167] @audius/fixed-decimal: A data structure for fixed precision decimals (#6662) Marcus Pasell [bdee772] Fix harmony docs sidebar-item (#6690) Dylan Jeffers [5dffb42] Fix Flex prop leaking, Upgrade Box (#6686) Dylan Jeffers [ae9e668] Hotfix double gzip on mobile for Content Nodes (#6687) Theo Ilie [48154d5] Add pay-gated upload test and re-enable stems test (#6681) Raymond Jacobson [bb0f2a4] Bump version to 0.5.16 audius-infra [7937393] Add text-shadow, fix avatar className, add 2xs spacing (#6682) Dylan Jeffers [0f0429a] Fix broken useAccountHasClaimableRewards (#6683) Reed [e5da54d] [PROTO-1418] Add dynamically imported Audius libs to /up app (#6680) Theo Ilie [5bb8a96] [PAY-1955] Fix purchases, sales, withdrawals text overflow (#6669) Saliou Diallo [a75a1e5] [C-3294] Add Harmony PlainButton docs (#6678) Kyle Shanks [445cec1] Fix typography header xl font-size and line-height (#6677) Dylan Jeffers [e5d53dc] Ignore animations in Chromatic (#6676) Dylan Jeffers [c91486c] [C-3278] Add TextLink component and docs (#6661) Andrew Mendelsohn [9b4a017] Fix emotion support in web (#6675) Dylan Jeffers [c474b2a] [Sign up Redesign] Sign up white screens footer (web); add shadow mid inver to Harmony C-3358 C-3359ted (#6671) nicoback2 [0b0aedd] [INF-546] Ensure that vite base is set properly in prod builds (#6674) Sebastian Klingler [29f1466] [C-3244] Fix heading text clipping (#6670) Dylan Jeffers [57b8ddc] Only announce prod client deploys (#6673) Raymond Jacobson [ef80e97] Add back react-native symlink step in CI (#6672) Sebastian Klingler [e52b8c2] Add no-constant-binary-expression eslint rule (#6666) Sebastian Klingler [02b28d7] Fix trpc endpoints w/ vite (#6668) Sebastian Klingler [c358e17] Disable ToS banner (#6665) Raymond Jacobson [183434d] [PAY-2151] Create Pay & Earn Page (#6654) Reed [e313506] Fix vite webworker basename issue (#6667) Raymond Jacobson [3ded93c] [C-3274, C-3348] Add README to Harmony (#6663) Kyle Shanks [5ff8e61] Bump version to 0.5.15 audius-infra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes harmony types due to internal absolute imports. The fix, like we did with common, is to add the transform-paths typescript plugin which rewrites absolute imports as relative imports when building
How Has This Been Tested?
No typescript issues + we get proper type checking in web