Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C-3527] Add native artist previews #6989

Merged
merged 4 commits into from
Dec 21, 2023
Merged

[C-3527] Add native artist previews #6989

merged 4 commits into from
Dec 21, 2023

Conversation

dylanjeffers
Copy link
Contributor

@dylanjeffers dylanjeffers commented Dec 19, 2023 •
edited
Loading

Description

  • Adds native artist previews
  • Renames audio to audio-player
  • Fixes "already initted/ not initted" player warnings by ensuring init happens right at top of app
  • Moves audio-player into the "app stack" so it doesn't conflict with usage in sign-up flow
  • Improves follow-button when it's a checkbox
Screen.Recording.2023-12-19.at.4.38.02.PM.mov

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
audius-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 6:57am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
audius-web-ssr ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 6:57am

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/dj-c-3527-native-artist-previews

DejayJD
DejayJD reviewed Dec 20, 2023
View reviewed changes
packages/mobile/src/harmony-native/components/Button/FollowButton/FollowButton.tsx
@@ -28,6 +28,7 @@ export const FollowButton = (props: FollowButtonProps) => {
const { disabled } = other
const [following, setFollowing] = useState(isFollowing)
const { color, cornerRadius } = useTheme()
const isInput = !!onChange
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever little add

DejayJD
DejayJD reviewed Dec 20, 2023
View reviewed changes
packages/mobile/src/screens/sign-on-screen/SignOnStack.tsx Outdated
@@ -15,7 +15,10 @@ const screenOptionsOverrides = { animationTypeForReplace: 'pop' as const }
export const SignOnStack = () => {
const screenOptions = useScreenOptions(screenOptionsOverrides)
return (
<Stack.Navigator initialRouteName='SignOn' screenOptions={screenOptions}>
<Stack.Navigator
initialRouteName='SelectArtists'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oop

DejayJD
DejayJD reviewed Dec 20, 2023
View reviewed changes
.../mobile/src/screens/sign-on-screen/screens/SelectArtistScreen/selectArtistPreviewContext.tsx
@@ -0,0 +1,109 @@
import { createContext, useCallback, useMemo, useState } from 'react'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This context looks clean af 👨‍🍳 👌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! copied liberally from @amendelsohn's implementation on web

DejayJD
DejayJD approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@DejayJD DejayJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@dylanjeffers dylanjeffers merged commit 3448af6 into main Dec 21, 2023
2 of 4 checks passed
@dylanjeffers dylanjeffers deleted the dj-c-3527-native-artist-previews branch December 21, 2023 06:57
schottra added a commit that referenced this pull request Dec 21, 2023
@schottra
Merge remote-tracking branch 'origin/main' into pay-1616-index-userba…
7b61530 
…nk-tests

* origin/main:
  [C-3539] Add harmony IconButton (#7004)
  Fix sdk Storage retry logic (#7006)
  Publish sdk and fix publish flow (#6995)
  ⚠️ [C-3538] Remove moment from common (#6992)
  Bump version to 0.6.7
  [C-3527] Add native artist previews (#6989)
  [PROTO-1524] Invalidate cache on refresh (#6996)
  Move ddex UI (#6990)
  As/fix profiles not loading (#6997)
  Ignore legacy images in indexing (#7003)
  Revert "Add Solana Support to SDK with sdk.users.sendTip() (#6891)" (#7002)
  Disable triggers while migration runs (#7001)
  Add Solana Support to SDK with sdk.users.sendTip() (#6891)
  fix es-indexer for local dev (#6999)
  Add lock to tracks table for migration (#6998)
  [PROTO-1500] Use created_at for release_date by default (#6982)
  [C-3427] Add BaseButton to mobile harmony (#6968)
audius-infra pushed a commit that referenced this pull request Dec 23, 2023
v1.5.57
daa5a9b 
[a6c645a] Add chargebackProtectionData (#7021) Raymond Jacobson
[b71a0d4] Simple upload UI (#7023) Michelle Brier
[389724e] Make CI sed more specific (#7024) Theo Ilie
[02a7126] Add back protocol dashboard improvements (#7022) Theo Ilie
[5652852] [Discovery] Discovery lint fix (#7020) nicoback2
[b48bb0d] [Discovery] Fix response marshalling - Dashboard Wallet Users API (#7019) nicoback2
[85f9b7f] Revert protocol dashboard changes (#7017) Theo Ilie
[a8f0282] Hotfix adding missing scripts to Dockerfile (#7015) Theo Ilie
[b759e93] Bump version to 0.6.8 audius-infra
[179ba8a] [SDK] Add dashboard wallet users API to SDK [C-3530] (#6971) nicoback2
[3c92e3d] [PROTO-1546] Limit mediorum ffmpeg CPU and filter ffmpeg logs (#6988) Theo Ilie
[d494ced] [Discovery] Add bulk get dashboard wallet users to Discovery Api [C-3532] (#6984) nicoback2
[108a688] Build protocol dashboard 84x smaller in CI instead of at runtime (#7014) Theo Ilie
[9e337d5] Add ddex to audius-compose and improve its build (#7013) Theo Ilie
[d364016] Lower thresholds for prune and full prune on self-hosted ci machines (#7012) Danny
[0b47999] [PAY-1872] Add tests for USDC user bank indexer (#7009) Randy Schott
[787f68c] [PAY-2315] Explicitly cancel transaction when closing coinflow drawer (#7011) Randy Schott
[6ea1880] Index EM transactions for dashboard wallet users C-3529 (#6969) nicoback2
[276540b] Temporarily remove ddex image as required for releases (#7008) Theo Ilie
[0360ee3] [C-3539] Add harmony IconButton (#7004) Dylan Jeffers
[a002560] Fix sdk Storage retry logic (#7006) Sebastian Klingler
[500f9a7] Publish sdk and fix publish flow (#6995) Sebastian Klingler
[759c52d] ⚠️ [C-3538] Remove moment from common (#6992) Raymond Jacobson
[12cfb9d] Bump version to 0.6.7 audius-infra
[3448af6] [C-3527] Add native artist previews (#6989) Dylan Jeffers
[4701dec] [PROTO-1524] Invalidate cache on refresh (#6996) Dylan Jeffers
[a9c2f78] Move ddex UI (#6990) Michelle Brier
[b67d52a] As/fix profiles not loading (#6997) alecsavvy
[7d2dd60] Ignore legacy images in indexing (#7003) Isaac Solo
[9eefe64] Revert "Add Solana Support to SDK with sdk.users.sendTip() (#6891)" (#7002) Marcus Pasell
[97e8ae3] Disable triggers while migration runs (#7001) Theo Ilie
[a542274] Add Solana Support to SDK with sdk.users.sendTip() (#6891) Marcus Pasell
[f2a2ce1] fix es-indexer for local dev (#6999) Steve Perkins
[b2c900e] Add lock to tracks table for migration (#6998) Theo Ilie
[9e3dd6e] [PROTO-1500] Use created_at for release_date by default (#6982) Theo Ilie
[bd88bfe] [C-3427] Add BaseButton to mobile harmony (#6968) Kyle Shanks
[aa3d301] Publish @audius/spl (#6991) Sebastian Klingler
[e3bb2f3] Bump version to 0.6.6 audius-infra
[2109fdf] Lint fixes for edit album (#6977) Andrew Mendelsohn
[a46ca96] fix non responsive node attestation (#6966) alecsavvy
[8967859] Fix sdk write w/ vite and fix npm publish (#6986) Sebastian Klingler
[2195a03] Schedule release follow ons (#6985) Isaac Solo
[7f0f242] [C-3528] Add harmony animated icons (#6981) Dylan Jeffers
[4582d43] [C-3494] Add shadow to icon (#6980) Dylan Jeffers
[a9d2924] [C-3447] Add select-artist native screen (#6955) Dylan Jeffers
[b6c7aae] bump multiformats version (#6983) alecsavvy
[17043de] Bump version to 0.6.5 audius-infra
[2d72cef] [C-3519] Fix async absolute lottie imports (#6976) Dylan Jeffers
[7f78919] [C-3535] Fix harmony icon types (#6979) Dylan Jeffers
[e045809] Update key for tos banner version (#6978) Raymond Jacobson
[c9a3e7c] Update ToS (#6973) Raymond Jacobson
[7667fee] [PAY-2296] Adds additional metadata to Coinflow purchases (#6975) Randy Schott
[cfb3c91] [C-3518] Fix user-list issues, sign-up navigation issue (#6974) Dylan Jeffers
[c1d0e85] Quick fix to use release_date for feed ordering (#6972) Steve Perkins
[435a464] [PAY-2293][PAY-2292] Add coinflow updates (#6967) Raymond Jacobson
[4d7f23a] Revert "[PAY-2276] Selectable amounts for coinflow add funds web (#69… (#6970) Raymond Jacobson
[9274a11] [C-3511] Add Track to Album (mobile + mobile web) (#6962) Andrew Mendelsohn
[a9a0001] Bump version to 0.6.4 audius-infra
[add67ba] Default to Stripe (#6963) Marcus Pasell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DejayJD DejayJD DejayJD approved these changes

@Kyle-Shanks Kyle-Shanks Awaiting requested review from Kyle-Shanks

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylanjeffers @audius-infra @DejayJD