Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChallengesApi, RewardManager to SDK #7026

Merged
merged 70 commits into from
Jan 24, 2024

add missing wallets

604d044
Select commit
Loading
Failed to load commit list.
Merged

Add ChallengesApi, RewardManager to SDK #7026

add missing wallets
604d044
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks completed Jan 24, 2024 in 4s

14 secrets uncovered!

14 secrets were uncovered from the scan of 70 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #7026: mjp-sdk-solana-relay-2 👉 main
GitGuardian id Secret Commit Filename
688750 Generic High Entropy Secret b49d575 packages/ddex/client/.env.dev View secret
688750 Generic High Entropy Secret b49d575 packages/ddex/client/.env.stage.local View secret
2111319 Generic High Entropy Secret b49d575 packages/mobile/src/env/env.prod.ts View secret
2111319 Generic High Entropy Secret b49d575 packages/web/src/services/env/env.prod.ts View secret
2111320 Generic High Entropy Secret b49d575 packages/mobile/src/env/env.stage.ts View secret
2111320 Generic High Entropy Secret b49d575 packages/web/src/services/env/env.stage.ts View secret
2416684 Generic High Entropy Secret b49d575 packages/ddex/client/.env.stage.local View secret
2416685 Generic High Entropy Secret b49d575 packages/ddex/client/.env.stage.local View secret
2416686 Generic High Entropy Secret b49d575 packages/ddex/client/.env.stage.local View secret
2858199 Generic High Entropy Secret b49d575 packages/mobile/src/env/env.stage.ts View secret
2858199 Generic High Entropy Secret b49d575 packages/web/src/services/env/env.stage.ts View secret
3939057 Generic High Entropy Secret b49d575 packages/ddex/client/.env.dev View secret
9200270 Generic High Entropy Secret b49d575 packages/ddex/server/.env.stage View secret
9349019 Generic High Entropy Secret b49d575 packages/ddex/server/.env.stage View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!