Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Fix more icon issues after Harmony migration C-3789 #7515

Merged
merged 1 commit into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
border-color: var(--neutral-light-7);
background: var(--neutral-light-8);
}
.show.actionsSection .actionButton:active g path {
.show.actionsSection .actionButton:active path {
fill: var(--neutral);
}

Expand Down
4 changes: 2 additions & 2 deletions packages/web/src/components/banner/Banner.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
.iconRemove:active {
transform: scale(0.95);
}
.iconSave g path,
.iconRemove g path {
.iconSave path,
.iconRemove path {
fill: var(--static-white);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,6 @@
width: var(--unit-4);
}

.arrow g path {
.arrow path {
fill: var(--static-white);
}
4 changes: 2 additions & 2 deletions packages/web/src/components/card/desktop/Card.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
cursor: pointer;
}

.iconContainer:hover g path {
.iconContainer:hover path {
fill: #858199;
}

Expand All @@ -161,7 +161,7 @@
height: 5px;
}

.iconKebabHorizontal g path {
.iconKebabHorizontal path {
fill: var(--neutral-light-4);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
margin-right: 4px;
}

.createPlaylistButton g path {
.createPlaylistButton path {
transition: all ease-in-out 0.04s;
fill: var(--neutral-light-2);
}
Expand All @@ -28,7 +28,7 @@
color: var(--neutral);
transform: scale(1.02);
}
.createPlaylistButton:hover g path {
.createPlaylistButton:hover path {
fill: var(--neutral);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
height: 10px;
}

.caret g path {
.caret path {
fill: var(--white);
}

Expand Down
4 changes: 2 additions & 2 deletions packages/web/src/components/drawer/Drawer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
} from 'react'

import { useInstanceVar } from '@audius/common/hooks'
import { IconRemove } from '@audius/harmony'
import { IconClose } from '@audius/harmony'
import { disableBodyScroll, clearAllBodyScrollLocks } from 'body-scroll-lock'
import cn from 'classnames'
// eslint-disable-next-line no-restricted-imports -- TODO: migrate to @react-spring/web
Expand Down Expand Up @@ -397,7 +397,7 @@ const FullscreenDrawer = ({
}}
>
<div className={styles.dismissContainer} onClick={onClose}>
<IconRemove />
<IconClose size='s' />
</div>
{children}
</animated.div>
Expand Down
8 changes: 4 additions & 4 deletions packages/web/src/components/more/More.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@
margin-left: 6px;
width: 9px;
}
.more.light .iconArrow g path {
.more.light .iconArrow path {
fill: var(--neutral-light-4);
}
.more.dark .iconArrow g path {
.more.dark .iconArrow path {
fill: var(--neutral);
}
.more.light:hover .iconArrow g path {
.more.light:hover .iconArrow path {
fill: var(--neutral-light-2);
}
.more.dark:hover .iconArrow g path {
.more.dark:hover .iconArrow path {
fill: var(--neutral-light-1);
}
8 changes: 4 additions & 4 deletions packages/web/src/components/nav/desktop/RouteNav.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,17 @@
transition: all 0.07s ease-in-out;
}

.backButton g path,
.forwardButton g path {
.backButton path,
.forwardButton path {
fill: var(--neutral-light-4);
}

.forwardButton:hover {
transform: scale(1.1);
}

.backButton:hover g path,
.forwardButton:hover g path {
.backButton:hover path,
.forwardButton:hover path {
fill: var(--neutral-light-2);
}

Expand Down
1 change: 1 addition & 0 deletions packages/web/src/components/navigation/Dropdown.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
.dropdown.disabled:hover {
border-color: var(--neutral-light-8);
}
.dropdown.disabled path,
.dropdown.disabled g path {
fill: var(--neutral-light-4);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,45 +7,25 @@
composes: icon;
}

.iconFollow g {
fill: var(--secondary);
}

.iconRepost {
composes: icon;
height: 18px;
}

.iconRepost g path {
fill: var(--secondary);
}

.iconFavorite {
composes: icon;
}

.iconFavorite g path {
fill: var(--secondary);
}

.iconMilestone {
composes: icon;
height: 24px;
}

.iconMilestone g path {
fill: var(--secondary);
}

.iconRelease {
composes: icon;
height: 28px;
}

.iconRelease g path {
fill: var(--secondary);
}

.iconRewards {
margin-right: var(--unit-2);
}
Expand All @@ -58,23 +38,10 @@
composes: icon;
}

.iconTrending g path {
fill: var(--secondary);
}

.iconTier {
margin-right: var(--unit-2);
}

.iconCart {
composes: icon;
height: var(--unit-6);
}

.iconCart path {
fill: var(--secondary);
}

.iconTier img {
height: 32px;
width: 32px;
Expand All @@ -85,28 +52,12 @@
height: 24px;
}

.iconRemix g path {
fill: var(--secondary);
}

.iconTip {
composes: icon;
height: 24px;
}

.iconTip path {
fill: var(--secondary);
}

.iconAnnouncement g path {
fill: var(--secondary);
}

.iconAddTrackToPlaylist {
composes: icon;
height: 24px;
}

.iconAddTrackToPlaylist g path {
fill: var(--secondary);
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@
left: 0px;
}

.header .iconRemove g path {
.header .iconRemove path {
fill: var(--neutral-light-4);
}

.header .iconRemove:hover {
transform: scale(1.1);
}

.header .iconRemove:hover g path {
.header .iconRemove:hover path {
fill: var(--neutral);
}

Expand Down
4 changes: 0 additions & 4 deletions packages/web/src/components/pill/Pill.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,3 @@
width: 12px;
height: 12px;
}

.pill .icon g path {
fill: var(--neutral-light-3);
}
5 changes: 3 additions & 2 deletions packages/web/src/components/search/SearchBar.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,9 @@ class SearchBar extends Component {
<div>
<span>View More Results</span>
<IconArrow
height={'7px'}
width={'7px'}
color='default'
height={8}
width={8}
className={styles.iconArrow}
/>
</div>
Expand Down
1 change: 0 additions & 1 deletion packages/web/src/components/search/SearchBar.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@
> div
> div
> .iconArrow
g
path {
fill: var(--white);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
border-top: none;
}

.shareToTwitterAction g path {
.shareToTwitterAction path {
fill: var(--static-twitter-blue);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
opacity: 0;
}

.icon g path {
.icon path {
fill: var(--neutral-light-5);
}
.tableOptionsButton:hover .icon {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
margin-top: 2px;
}

.topBannerIcon svg g path {
.topBannerIcon svg path {
fill: var(--white);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/web/src/components/track/TrackInfo.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
.volumeIcon svg {
height: 8px;
}
.volumeIcon g path {
.volumeIcon path {
fill: var(--primary);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@
height: 65%;
}

.artworkIcon g path {
.artworkIcon g path,
.artworkIcon path {
fill: rgba(255, 255, 255, 0.75);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/web/src/components/upload/PreviewButton.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class PreviewButton extends Component {
</div>
) : (
<div>
<IconPlay className={styles.previewButton} />
<IconPlay color='default' className={styles.previewButton} />
</div>
)}
<span>Preview</span>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,21 +130,3 @@
width: 200px;
height: 200px;
}

.iconRemove {
position: absolute;
top: 24px;
left: 24px;
height: 24px;
width: 24px;
cursor: pointer;
}
.iconRemove:hover {
transform: scale(1.1);
}
.iconRemove:active {
transform: scale(0.95);
}
.iconRemove g path {
fill: var(--neutral-light-4);
}
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@
margin-right: 20px;
}

.achievementTrophy g path {
.achievementTrophy path {
fill: var(--secondary);
}
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
width: 12px;
height: 12px;
}
.historyPageWrapper :global(.ant-input-prefix) > svg g path {
.historyPageWrapper :global(.ant-input-prefix) > svg path {
fill: var(--neutral-light-4);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@
margin-bottom: 8px;
}

.name > .editNameContainer > .iconPencil g path {
fill: var(--static-white);
}

.editNameContainer {
line-height: normal;
width: 100%;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
width: 20px;
}

.pickForMe:hover .iconWand g path {
.pickForMe:hover .iconWand path {
fill: var(--neutral-light-2);
}

Expand Down
Loading