-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new Protocol Dashboard Overview Page [C-3752] #7618
Implement new Protocol Dashboard Overview Page [C-3752] #7618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crushed it!
any sense why sometimes single quotes are used and sometimes double? is our linter just weird in this repo?
<Flex direction="column" gap="xs"> | ||
<Flex gap="xs" alignItems="center"> | ||
<Text variant="heading" size="s" strength="default" tag="span"> | ||
{audiusProfile.name}{' '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would padding right work instead of empty str?
@@ -33,12 +21,11 @@ | |||
text-align: center; | |||
letter-spacing: 0.04em; | |||
text-transform: uppercase; | |||
color: #BEC5E0; | |||
color: #bec5e0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have this color in harmony?
wtf2: `It does this by being fully decentralized: Audius is owned and run by a vibrant, open-source community of artists, fans, and developers all around the world. Audius gives artists the power to share never-before-heard music and monetize streams directly. Developers can build their own apps on top of Audius, giving them access to one of the most unique audio catalogs in existence.`, | ||
wtf3: `Backed by an all-star team of investors, Audius was founded in 2018 and serves millions of users every month, making it the largest non-financial crypto application ever built.` | ||
wtfIsAudius: 'What is Audius?', | ||
wtf1: `Audius is not just a digital streaming platform; it's a revolution that connects fans and artists, bringing exclusive new music to your fingertips.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wtf lives on
} | ||
|
||
const Home = () => { | ||
const { isLoggedIn } = useAccount() | ||
const { recentProposals } = useProposals() | ||
const pushRoute = usePushRoute() | ||
const isMobile = useIsMobile() | ||
const { typography } = useTheme() as HarmonyTheme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this typecast necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah for some reason the type is wrong when imported from harmony. will add a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing!
In the screenshot you posted, the big metrics have an almost imperceptible box shadow. You can see if if you zoom in, idk if that's just a jpeg artifact or something.
@@ -5,7 +5,7 @@ import { useAnnualRewardRate } from 'hooks/useRewardRate' | |||
import { Status } from 'types' | |||
|
|||
const messages = { | |||
label: `ESTIMATED ANNUAL REWARD RATE` | |||
label: `Annual` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: no backticks needed here
wtf2: `It does this by being fully decentralized: Audius is owned and run by a vibrant, open-source community of artists, fans, and developers all around the world. Audius gives artists the power to share never-before-heard music and monetize streams directly. Developers can build their own apps on top of Audius, giving them access to one of the most unique audio catalogs in existence.`, | ||
wtf3: `Backed by an all-star team of investors, Audius was founded in 2018 and serves millions of users every month, making it the largest non-financial crypto application ever built.` | ||
wtfIsAudius: 'What is Audius?', | ||
wtf1: `Audius is not just a digital streaming platform; it's a revolution that connects fans and artists, bringing exclusive new music to your fingertips.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: backticks
ohh weird, not sure but ill try to make them all uniform |
Description
Implement new dashboard overview page.
Includes:
How Has This Been Tested?
Locally
Follow up tasks (put in Linear)