Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new Protocol Dashboard Overview Page [C-3752] #7618

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

nicoback2
Copy link
Contributor

@nicoback2 nicoback2 commented Feb 16, 2024

⚠️ Will be merged into a feature branch

Description

Implement new dashboard overview page.
Includes:

  • Visual updates
  • New delegate card for each of the user's delegates showing est rewards from that specific delegate
  • New card w/ current round info + ability to initiate new round if possible
  • Updated "Audius" section

How Has This Been Tested?

Locally
screencapture-localhost-5173-2024-02-15-16_29_29

Follow up tasks (put in Linear)

  • Mobile styling
  • Tooltips
  • Add iPhone pic to "What is Audius" (need to get progressive loading img from Julian when he's back)

@nicoback2 nicoback2 changed the title Implement new Protocol Dashboard Overview Page Implement new Protocol Dashboard Overview Page [C-3752] Feb 16, 2024
Base automatically changed from nkang--harmony to main February 16, 2024 01:04
Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crushed it!

any sense why sometimes single quotes are used and sometimes double? is our linter just weird in this repo?

<Flex direction="column" gap="xs">
<Flex gap="xs" alignItems="center">
<Text variant="heading" size="s" strength="default" tag="span">
{audiusProfile.name}{' '}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would padding right work instead of empty str?

@@ -33,12 +21,11 @@
text-align: center;
letter-spacing: 0.04em;
text-transform: uppercase;
color: #BEC5E0;
color: #bec5e0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have this color in harmony?

wtf2: `It does this by being fully decentralized: Audius is owned and run by a vibrant, open-source community of artists, fans, and developers all around the world. Audius gives artists the power to share never-before-heard music and monetize streams directly. Developers can build their own apps on top of Audius, giving them access to one of the most unique audio catalogs in existence.`,
wtf3: `Backed by an all-star team of investors, Audius was founded in 2018 and serves millions of users every month, making it the largest non-financial crypto application ever built.`
wtfIsAudius: 'What is Audius?',
wtf1: `Audius is not just a digital streaming platform; it's a revolution that connects fans and artists, bringing exclusive new music to your fingertips.`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf lives on

}

const Home = () => {
const { isLoggedIn } = useAccount()
const { recentProposals } = useProposals()
const pushRoute = usePushRoute()
const isMobile = useIsMobile()
const { typography } = useTheme() as HarmonyTheme
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this typecast necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah for some reason the type is wrong when imported from harmony. will add a comment

Copy link
Contributor

@sliptype sliptype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing!

In the screenshot you posted, the big metrics have an almost imperceptible box shadow. You can see if if you zoom in, idk if that's just a jpeg artifact or something.

@@ -5,7 +5,7 @@ import { useAnnualRewardRate } from 'hooks/useRewardRate'
import { Status } from 'types'

const messages = {
label: `ESTIMATED ANNUAL REWARD RATE`
label: `Annual`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no backticks needed here

wtf2: `It does this by being fully decentralized: Audius is owned and run by a vibrant, open-source community of artists, fans, and developers all around the world. Audius gives artists the power to share never-before-heard music and monetize streams directly. Developers can build their own apps on top of Audius, giving them access to one of the most unique audio catalogs in existence.`,
wtf3: `Backed by an all-star team of investors, Audius was founded in 2018 and serves millions of users every month, making it the largest non-financial crypto application ever built.`
wtfIsAudius: 'What is Audius?',
wtf1: `Audius is not just a digital streaming platform; it's a revolution that connects fans and artists, bringing exclusive new music to your fingertips.`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: backticks

@nicoback2
Copy link
Contributor Author

crushed it!

any sense why sometimes single quotes are used and sometimes double? is our linter just weird in this repo?

ohh weird, not sure but ill try to make them all uniform

@nicoback2 nicoback2 changed the base branch from main to feature--protodash-ux February 20, 2024 16:40
@nicoback2 nicoback2 merged commit 93dc26f into feature--protodash-ux Feb 20, 2024
5 of 6 checks passed
@nicoback2 nicoback2 deleted the nkang--protodash-overview-page branch February 20, 2024 18:20
nicoback2 added a commit that referenced this pull request Mar 14, 2024
Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants