[C-4002] Remove all stems buttons in web #7848

dylanjeffers · 2024-03-15T01:21:46Z

Description

Removes all stems buttons in web. should be merged after the "common" button pr is

sliptype

Such a huge change!

What is our testing strategy for this? I wanna avoid another red icons scare

sliptype · 2024-03-15T19:24:17Z

packages/web/src/components/app-redirect-popover/components/AppRedirectPopover.tsx

@@ -128,6 +128,8 @@ export const AppRedirectPopover = (props: AppRedirectPopoverProps) => {
  )
  const drawerTransitions = useTransition(shouldShow, null, springProps.drawer)

+  console.log({ shouldShow })


sliptype · 2024-03-15T19:25:37Z

packages/web/src/components/artist/ArtistCard.tsx

 import { useDispatch } from 'react-redux'

-import { FollowButton } from 'components/follow-button/FollowButton'
+// import { FollowButton } from 'components/follow-button/FollowButton'


sliptype · 2024-03-15T19:27:13Z

packages/web/src/components/collectibles/components/CollectiblesPage.tsx

@@ -582,42 +584,40 @@ const CollectiblesPage = (props: CollectiblesPageProps) => {
          </div>

          {isMobile ? (
-            <div className={styles.mobileButtonContainer}>
+            <Flex gap='s' w='100%'>


Harmony all the things!

sliptype · 2024-03-15T19:28:14Z

packages/web/src/components/collection/desktop/OwnerActionButtons.tsx

@@ -46,7 +46,7 @@ export const OwnerActionButtons = (props: OwnerActionButtonProps) => {
        />
      ) : null}

-      {!is_private ? (
+      {is_private ? (


sliptype · 2024-03-15T19:33:40Z

packages/web/src/components/social-button/tiktok-button/TikTokButton.tsx

-      className={cn(styles.button, props.className)}
-    />
-  )
+  return <SocialButton socialType='tiktok' {...props} />


This almost feels like we don't need a separate file for

yeah we truly don't, but it's referenced in like 5 spots so it was a bit much. now that things are operational though, ill take another look

sliptype · 2024-03-15T19:33:56Z

packages/web/src/components/stat-banner/StatBanner.tsx

 } from '@audius/harmony'
 import cn from 'classnames'

 import { ArtistRecommendationsPopup } from 'components/artist-recommendations/ArtistRecommendationsPopup'
-import { FollowButton } from 'components/follow-button/FollowButton'
+// import { FollowButton } from 'components/follow-button/FollowButton'


sliptype · 2024-03-15T19:35:03Z

packages/web/src/components/tipping/support/SupportingList.tsx

@@ -67,7 +67,7 @@ const SupportingListForProfile = ({ profile }: { profile: User }) => {
      {profile.supporting_count > MAX_PROFILE_SUPPORTING_TILES && (
        <div className={styles.seeMore} onClick={handleClick}>
          <span>{formatViewAllMessage(profile.supporting_count)}</span>
-          <IconArrow className={styles.arrowIcon} />
+          <IconArrow size='m' />


Can prob delete arrowIcon styles

sliptype · 2024-03-15T19:46:32Z

...s/web/src/pages/settings-page/components/desktop/DeveloperApps/DeleteAppConfirmationPage.tsx

@@ -79,26 +77,23 @@ export const DeleteAppConfirmationPage = (
    <div>
      <h4 className={styles.header}>{name}</h4>
      <p className={styles.confirmation}>{messages.confirmation}</p>
-      <ModalFooter className={styles.deleteAppFooter}>
+      <ModalFooter css={{ paddingBottom: `0 !important` }}>


for your context its cause modal-footer uses css-module. but when we migrate it, this can go away

dylanjeffers · 2024-03-15T20:00:58Z

Such a huge change!

What is our testing strategy for this? I wanna avoid another red icons scare

I'm thinking I don't merge this until next week so we get a full week to test in stage. Additionally I combed through all the buttons manually so I think we are looking pretty decent

audius-infra · 2024-03-16T00:15:54Z

Preview this change https://demo.audius.co/rest-of-buttons

[29de055] [C-4002] Remove all stems buttons in web (#7848) Dylan Jeffers [a70643a] [C-3967] Migrate common buttons to harmony (#7832) Dylan Jeffers [181429a] Mjp unlisted tracks (#7860) Marcus Pasell [5c0017e] Allow querying for unlisted tracks by ID (#7858) Marcus Pasell [5ab22b0] Move some tasks to new standalone index_sol worker (#7856) Theo Ilie [9610aa5] Parse more ddex fields (#7854) Michelle Brier [77078ae] [ONC-52] Self-re-enqueue user_bank and payment_router indexing tasks (#7842) Theo Ilie [b702fe5] [INF-667] Add create-audius-app (#7846) Sebastian Klingler [b2c41ba] Bump version to 0.6.60 audius-infra [b63c0a4] [C-3954] Expand sentry use in sign up (#7830) JD Francis [920dbde] Add aggregate_monthly_plays_country_backfill (#7835) Steve Perkins [3c10eda] fix aao error log (#7850) alecsavvy [10c9574] Fix lint (#7852) Raymond Jacobson [132307b] Fix micro lamports in jupiter (#7851) Raymond Jacobson [3acab52] Fix jupiter instruction (#7849) Raymond Jacobson [09bb489] [⚠️] Use vite swc react (#7845) Raymond Jacobson [49c0dff] Add amplitude event for account creation (#7844) JD Francis [0177770] [Protocol Dashboard] Disable Manage delegation button when claim is pending [C-4000] (#7843) nicoback2 [43dcaf6] [Protocol Dashboard] Merge Protocol Dashboard UX Improvements feature branch into main (#7841) nicoback2 [c69674b] [PAY-2557] Add PREMIUM_ALBUMS_ENABLED feature flag (#7840) Reed [0fa48a8] Bump harmony and consume in examples/react (#7837) Sebastian Klingler [d68f6e1] fix circular dep (#7839) alecsavvy [9ec3eda] Remove custom Sentry fingerprint (#7833) Marcus Pasell [f40d0cb] Fix embed build and use turbo (#7836) Sebastian Klingler [d48038d] [PAY-2409] Clean up old download code (#7820) Saliou Diallo [f387341] Bump version to 0.6.59 audius-infra [94f3fe4] [INF-593] Add react + ts + @audius/sdk example app (#7807) Sebastian Klingler [38cff27] PROTO-1720: relay logging (#7834) alecsavvy [751df35] Parse and store all DDEX standard identitiers (#7818) Michelle Brier [7c77df0] Add more priority fees across all solana transactions (#7831) Raymond Jacobson [6761fb3] [PAY-2549] Make comms come up by default (#7817) Raymond Jacobson [898f45a] [C-3743] Fix avatar styles on local (#7824) Dylan Jeffers [beb893d] .gitsha => gitsha.json (#7827) Marcus Pasell [40df28e] [C-3957] Remove legacy sign up (#7805) Dylan Jeffers [f7e8dee] Fix wallet check (#7829) Dylan Jeffers [f91ac3f] [DVRL-18] - formatting and port warnings (#7823) Sam Gutentag [f1837b6] Bump mobile app versions for full release (#7826) nicoback2 [c2b49f8] [C-3966] Don't require premium album fields (#7825) Andrew Mendelsohn [aab8aaa] [INF-668] Remove peerDeps from @audius/harmony (#7822) Sebastian Klingler [a3a41da] Fix react-native-datepicker on xcode 15.3 (#7816) Dylan Jeffers [cec7b35] .gitsha: update the correct worker this time (#7821) Marcus Pasell [a6da7d7] push solana relay in ci (#7806) alecsavvy [e841490] Add country column to aggregate_monthly_plays (#7801) Steve Perkins [e6267f1] [ONC-39] Check that signed in user matches wallet (#7812) Raymond Jacobson [c966eae] [ONC-30] Fix playlist trending filters (#7809) Raymond Jacobson [7b49daf] [PAY-2546] Fix stems and downloads text variant (#7810) Saliou Diallo [f694148] [PAY-2518] Fix android bug for combined downloads file in same folder (#7819) Saliou Diallo [f7cd6d3] Bump version to 0.6.58 audius-infra [339deab] [Mobile] ⚠️ Install pending CodePush update upon foregrounding after 1hr [C-3791] (#7661) nicoback2 [be14870] [ONC-46] Fix buy audio slippage (#7813) Raymond Jacobson [0f8521a] [C-3960] Fix user-generated-text tag (#7815) Dylan Jeffers [fdf0ade] [C-3965] Fix explore tiles (#7814) Dylan Jeffers [9f159f5] Fix harmony icon stories (#7800) Dylan Jeffers [ff70555] [C-3955] Migrate primary buttons to harmony (#7794) Dylan Jeffers [12fc68a] [ONC-47] Fix playlist/album upload stream gating check (#7811) Raymond Jacobson [5d8fd5b] Remove idle status in dashboard (#7808) Raymond Jacobson [13eae32] [C-2459] Remove share sound to tiktok (#7804) Dylan Jeffers [2c6f989] [ONC-45] Fix small kebab (#7802) Raymond Jacobson [739eefe] [Web] Fix Send Tip modal header icon and Download Page cloud icons [C-3952] (#7803) nicoback2 [df71a30] Convert @audius/common to vitest, add web tests to CI (#7797) Marcus Pasell [f11333d] Remove min delegation from identity, update subgraph (#7787) Raymond Jacobson [a4c6614] Add connect instagram ui (#7796) Raymond Jacobson [3f3e770] Postgres helper functions for debugging (#7799) Steve Perkins [1034daa] Bump version to 0.6.57 audius-infra [e0f7c64] Add .gitsha to .gitignore (#7798) Marcus Pasell [10299d2] [Discovery] Fix metrics APIs for year time range [C-3956] (#7795) nicoback2 [115303d] Move to 1k gold 10k platinum (#7791) Raymond Jacobson [cb0ef49] Bump mediorum play logging timeout to 60s (#7786) Theo Ilie [9641533] [C-3937] Fix new-playlist icon (#7792) Dylan Jeffers [b991afb] [C-3938] Fix harmony cache for SPA (#7789) Dylan Jeffers [464a07c] Add user.info.profile scope to tiktok redirect (#7788) Sebastian Klingler [0e024d5] [C-3887] Update suggested tracks logic to better handle deleted tracks and the race condition (#7785) Kyle Shanks [0a54eae] @audius/sdk: v3.0.39 audius-infra [f1d70a2] [INF-663] Fix external package versioning in monorepo (#7783) Sebastian Klingler [0cf37b7] Hotfix: Serve static .gitsha in cloudflare worker (#7781) Marcus Pasell [ca152db] Bump version to 0.6.56 audius-infra

This reverts commit 29de055.

[C-3967] Migrate common buttons to harmony

14c0b91

pull-request-size bot added the size/XXL label Mar 15, 2024

dylanjeffers requested review from a team and sliptype and removed request for a team March 15, 2024 01:22

sliptype approved these changes Mar 15, 2024

View reviewed changes

dylanjeffers added 10 commits March 15, 2024 15:39

Address comments

d879e14

Merge branch 'main' into dj-c-3967-common-buttons

15fefdf

Refactor rest of stems buttons

ba9e012

Refactor follow button

9aa3fca

Refactor social button

d215d31

Remove stems buttons entirely

28137ac

More css

e75a4fa

fix button widths

bd2afd9

Merge branch 'main' into rest-of-buttons

6df8be6

Address comments

477bd4c

dylanjeffers force-pushed the rest-of-buttons branch from 9e5166f to 477bd4c Compare March 16, 2024 00:02

dylanjeffers merged commit 29de055 into main Mar 16, 2024
23 of 27 checks passed

dylanjeffers deleted the rest-of-buttons branch March 16, 2024 03:54

dylanjeffers added a commit that referenced this pull request Mar 18, 2024

Revert "[C-4002] Remove all stems buttons in web (#7848)"

0ecedff

This reverts commit 29de055.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C-4002] Remove all stems buttons in web #7848

[C-4002] Remove all stems buttons in web #7848

dylanjeffers commented Mar 15, 2024 •

edited

Loading

sliptype left a comment

sliptype Mar 15, 2024

sliptype Mar 15, 2024

sliptype Mar 15, 2024

sliptype Mar 15, 2024

sliptype Mar 15, 2024

dylanjeffers Mar 15, 2024

sliptype Mar 15, 2024

sliptype Mar 15, 2024

sliptype Mar 15, 2024

dylanjeffers Mar 15, 2024

dylanjeffers commented Mar 15, 2024

audius-infra commented Mar 16, 2024

[C-4002] Remove all stems buttons in web #7848

[C-4002] Remove all stems buttons in web #7848

Conversation

dylanjeffers commented Mar 15, 2024 • edited Loading

Description

sliptype left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dylanjeffers commented Mar 15, 2024

audius-infra commented Mar 16, 2024

dylanjeffers commented Mar 15, 2024 •

edited

Loading