[PAY-2568] Add access field to playlists #7894

amendelsohn · 2024-03-20T20:17:34Z

Description

Return access for playlists to support sellable albums

How Has This Been Tested?

Checked that local stack returns access from playlists endpoints

gitguardian · 2024-03-20T20:17:57Z

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9349019	Triggered	Generic High Entropy Secret	`f5f2807`	packages/ddex/.env.dev	View secret
9349019	Triggered	Generic High Entropy Secret	`f5f2807`	dev-tools/config.json	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

dharit-tan · 2024-03-20T20:22:45Z

packages/discovery-provider/src/queries/query_helpers.py

-            track[response_name_constants.access] = {
+    for entity in entities:
+        content_id = getContentId(entity)
+        if content_id not in gated_content_ids:


i was gonna say i'm scared of id collisions between tracks and playlists, but since we only ever call this endpoint for tracks or playlists separately i think we're ok.

audius-infra · 2024-03-20T20:34:44Z

Preview this change https://demo.audius.co/am-album-access

audius-infra · 2024-03-20T20:47:45Z

Preview this change https://demo.audius.co/am-album-access

audius-infra · 2024-03-20T22:19:48Z

Preview this change https://demo.audius.co/am-album-access

audius-infra · 2024-03-20T22:56:59Z

Preview this change https://demo.audius.co/am-album-access

audius-infra · 2024-03-20T23:31:11Z

Preview this change https://demo.audius.co/am-album-access

dylanjeffers

I checked the content_access_checker. Hard to ensure total accuracy, but just had some comments after reading it for first time.

dylanjeffers · 2024-03-20T23:51:38Z

packages/discovery-provider/src/gated_content/content_access_checker.py

@@ -29,12 +30,13 @@ class ContentAccessResponse(TypedDict):
    has_download_access: bool


-GatedTrackAccessResult = Dict[int, Dict[int, ContentAccessResponse]]
+GatedContentAccessResult = Dict[int, Dict[int, ContentAccessResponse]]


 class ContentAccessBatchResponse(TypedDict):
    # track : user id -> track id -> access


do we want a similar comment or merged comment for the playlist addition?

given that they are typed with the same type, I'm not too worried about it, but can update the comment

dylanjeffers · 2024-03-20T23:55:36Z

packages/discovery-provider/src/gated_content/content_access_checker.py

+                    f"gated_content_access_checker.py | check_access_for_batch | no entity found for {content_type} {content_id}"
+                )
+                continue
+            if user_id not in batch_access_result[key_type]:


good improvement

dylanjeffers · 2024-03-20T23:58:56Z

packages/discovery-provider/src/gated_content/content_access_checker.py

+                }
+                continue
+
+            # if not gated on either stream or download,


does this comment make sense using the word "track" always now?

audius-infra · 2024-03-21T00:02:34Z

Preview this change https://demo.audius.co/am-album-access

amendelsohn · 2024-03-21T00:22:54Z

Ran test-audius-cmd and test discovery-provider locally. Other failed checks are also failing on main. Going ahead with merge.

[d09c970] Change internal sdk deps back to wildcard version (#7928) Sebastian Klingler [7271dbc] [C-4026, C-4059] Update profile page to render basic info and pictures on the server side (#7915) Kyle Shanks [bfde29f] Log error when retry on new node fails (#7924) Marcus Pasell [a5a0d96] [C-3961] Fix sign up modal toast triggers (#7916) JD Francis [0183bf8] [PROTO-1693] Fix tag search triggering autocomplete (#7913) Isaac Solo [eeb6e19] [C-4028] Harmony QA (#7919) Dylan Jeffers [fc94c44] [PROTO-1718] Parse DDEX subgenre and handle multiple genre elements (#7921) Theo Ilie [bf34d35] Bump version to 0.6.66 audius-infra [8c98f63] [C-4063] Add Sign on routes and aliases to static routes (#7918) Kyle Shanks [92ced07] [PROTO-1700] Make DDEX publisher support batched and local S3 (#7902) Theo Ilie [1f61df3] ⚠️ [C-4064] Fix empty feed/trending pages (#7920) Reed [6ea4bd7] boost relay retries and address in logging (#7914) alecsavvy [0c8911a] Misc accessibility improvements + mobile drawer fix (#7912) JD Francis [d62d210] [C-3962] Fix sign up referrals (#7880) JD Francis [61adb86] Bump version to 0.6.65 audius-infra [9d270a5] Fix remix uploads and AI attributed uploads (#7911) Marcus Pasell [4bc9f03] [C-4055] Improve modal and popover performance (#7909) Dylan Jeffers [befe0a5] [C-4027] Harmony migration fixes (#7907) Dylan Jeffers [5b3e9fa] Fix search autocomplete race condition (#7908) Isaac Solo [8f9d022] Fix ddex indexing (#7904) Michelle Brier [f1472a7] Re-add download to track api response for old clients (#7906) Reed [e2c7024] Improve search quality: genre, mood, tag, fuzziness, exact matches (#7883) Isaac Solo [efcb74e] [C-4024] Update SSR to dynamically import Root based on HYDRATE_CLIENT (#7892) Kyle Shanks [daf7c1e] Log retryTxId in TransactionHandler (#7895) Reed [38442bd] Bump version to 0.6.64 audius-infra [e0a0606] Pin docker to older version to fix regression (#7905) Danny [5f8aecc] [PAY-2577] Fix nft issues (#7884) Saliou Diallo [f27c8e1] ⚠️ Upload Saga Typed and Parallel Stems v2 (#7723) Marcus Pasell [4b4fd9b] fix nullable new fields in collection schema (#7903) Michelle Brier [d71ec07] [PAY-2568] Add access field to playlists (#7894) Andrew Mendelsohn [63ca5d4] Fix EM parsing of ddex fields (#7900) Michelle Brier [921a19e] Add undefined check to sentry navigator and remove profile page route (#7898) Kyle Shanks [73994e0] Add markdown-to-jsx to web (#7899) Dylan Jeffers [474a902] Remove is_downloadable from trending query (#7896) Reed [3fb1624] Fix collection search ranking in common (#7855) Isaac Solo [2a0a663] [C-3561] Remove playback delay on native (#7893) Dylan Jeffers [28f1150] Fix DDEX e2e tests (#7871) Michelle Brier [78add43] [Mediorum] [Discovery] Change `/services` protodash routes to `/nodes` (#7864) nicoback2 [8fb1fd9] [SDK] Enable User to User Grants [PAY-2544] (#7889) nicoback2 [184c576] [Discovery] Enable user to user grants ("delegated writes") aka manager mode [PAY-2544] (#7890) nicoback2 [a9b4c5e] Add missing containers for DDEX Docker build (#7891) Theo Ilie [e7b08ab] [C-4040, C-4032] Fix play cls, Fix pause on track screen (#7888) Dylan Jeffers [c876ae7] [C-4031, C-4039] Fix add to collection, Add fuzzy search (#7887) Dylan Jeffers [05a0bb3] Bump version to 0.6.63 audius-infra [93fed47] Fix discovery ddex fields (#7885) Michelle Brier [2f5f717] [C-4009] Remove stems styles and package (#7876) Dylan Jeffers [38e3a87] [C-4034] Fix feed tip tile (#7886) Dylan Jeffers [e4982a3] Bump mobile version for full-app-release (#7879) Dylan Jeffers [050a1b3] [C-4014] Fix red chat icons (#7882) Dylan Jeffers [f1edefd] [INF-672] Improve create-audius-app speed (#7866) Sebastian Klingler [c4ca5ca] [C-4025] Update profile page for ssr (#7881) Kyle Shanks [fdbcafc] fix solana relay build (#7872) alecsavvy [f84715f] Ignore sentry errors for probers (#7870) Marcus Pasell [2f17f53] Change loglevel to error in TransactionHandler _locallyConfirmTransaction (#7878) Reed [aeed7a3] [PROTO-1700] Update DDEX UI for batches and improved schema (#7877) Theo Ilie [062814a] [C-3958] Add StaticImage component and update track artwork rendering on web and mobile-web track pages for ssr (#7847) Kyle Shanks [a7e4c14] [C-4003] Fix sign up overflow issues on small devices (#7868) JD Francis [cb27af1] Misc Sign Up QA fixes (#7869) JD Francis [c259739] Bump version to 0.6.62 audius-infra [1d4f278] [C-4006] Remove all stems components (#7861) Dylan Jeffers [efb2b44] Fix audius-cmd test (#7874) Saliou Diallo [e32d515] Revert "Persist unused DDEX fields in discovery (#7862)" (#7873) Marcus Pasell [bd822ac] Add fixed-decimal to web deps and update version in libs (#7867) Reed [02b67d9] Document local audius-compose DDEX steps (#7865) Theo Ilie [f6bc750] Persist unused DDEX fields in discovery (#7862) Michelle Brier [e892314] [Protocol Dashboard] Requested changes to new Protocol Dashboard [C-4013] (#7863) nicoback2 [ed08d93] Related artists in sql (#7857) Steve Perkins [6cad61d] [C-3953] Perma-dismiss purple select artists banner on mobile (#7790) JD Francis [4cafd23] Bump version to 0.6.61 audius-infra [075f483] [PAY-2348][PAY-2317] Remove download json field from track metadata (#7784) Saliou Diallo

amendelsohn added 4 commits March 15, 2024 13:15

added access field to playlists; generated models

15d6ed0

lint

7b9ea48

Merge branch 'main' into am-album-access

f5f2807

remove unrelated lint fixes

ca57fab

amendelsohn requested review from rickyrombo, isaacsolo, dylanjeffers and sddioulde March 20, 2024 20:17

amendelsohn assigned dharit-tan Mar 20, 2024

pull-request-size bot added the size/XXL label Mar 20, 2024

dharit-tan reviewed Mar 20, 2024

View reviewed changes

dharit-tan approved these changes Mar 20, 2024

View reviewed changes

lint

86529c4

isaacsolo approved these changes Mar 20, 2024

View reviewed changes

add album support in check_access_for_batch

d63f285

amendelsohn added 2 commits March 20, 2024 15:32

fix types

e3c6cc6

regenerate models

070ea2c

pull-request-size bot added size/XL and removed size/XXL labels Mar 20, 2024

amendelsohn added 2 commits March 20, 2024 16:21

fix the test

a998d71

Merge branch 'main' into am-album-access

14560a6

fix tests

5c4e0b0

amendelsohn force-pushed the am-album-access branch from c2298ad to 5c4e0b0 Compare March 20, 2024 23:49

dylanjeffers approved these changes Mar 21, 2024

View reviewed changes

comments

5259a02

amendelsohn merged commit d71ec07 into main Mar 21, 2024
8 of 16 checks passed

amendelsohn deleted the am-album-access branch March 21, 2024 00:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PAY-2568] Add access field to playlists #7894

[PAY-2568] Add access field to playlists #7894

amendelsohn commented Mar 20, 2024

gitguardian bot commented Mar 20, 2024 •

edited

Loading

dharit-tan Mar 20, 2024

audius-infra commented Mar 20, 2024

audius-infra commented Mar 20, 2024

audius-infra commented Mar 20, 2024

audius-infra commented Mar 20, 2024

audius-infra commented Mar 20, 2024

dylanjeffers left a comment

dylanjeffers Mar 20, 2024

amendelsohn Mar 21, 2024

dylanjeffers Mar 20, 2024

dylanjeffers Mar 20, 2024

audius-infra commented Mar 21, 2024

amendelsohn commented Mar 21, 2024

[PAY-2568] Add access field to playlists #7894

[PAY-2568] Add access field to playlists #7894

Conversation

amendelsohn commented Mar 20, 2024

Description

How Has This Been Tested?

gitguardian bot commented Mar 20, 2024 • edited Loading

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

dharit-tan Mar 20, 2024

Choose a reason for hiding this comment

audius-infra commented Mar 20, 2024

audius-infra commented Mar 20, 2024

audius-infra commented Mar 20, 2024

audius-infra commented Mar 20, 2024

audius-infra commented Mar 20, 2024

dylanjeffers left a comment

Choose a reason for hiding this comment

dylanjeffers Mar 20, 2024

Choose a reason for hiding this comment

amendelsohn Mar 21, 2024

Choose a reason for hiding this comment

dylanjeffers Mar 20, 2024

Choose a reason for hiding this comment

dylanjeffers Mar 20, 2024

Choose a reason for hiding this comment

audius-infra commented Mar 21, 2024

amendelsohn commented Mar 21, 2024

gitguardian bot commented Mar 20, 2024 •

edited

Loading