Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C-4074] Add Dancehall genre #7947

Merged
merged 3 commits into from
Mar 26, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/common/src/utils/genres.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export enum Genre {
LATIN = 'Latin',
LOFI = 'Lo-Fi',
HYPERPOP = 'Hyperpop',
DANCEHALL = 'Dancehall',

// Electronic Subgenres
TECHNO = 'Techno',
Expand Down Expand Up @@ -118,6 +119,7 @@ export const GENRES = [
Genre.LATIN,
Genre.LOFI,
Genre.HYPERPOP,
Genre.DANCEHALL,
...Object.values(ELECTRONIC_SUBGENRES)
]

Expand Down
2 changes: 2 additions & 0 deletions packages/ddex/ingester/common/sdk_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ const (
JerseyClub Genre = "Jersey Club"
Vaporwave Genre = "Vaporwave"
Moombahton Genre = "Moombahton"
Dancehall Genre = "Dancehall"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing looks off here

)

var stringToGenre = map[string]Genre{
Expand Down Expand Up @@ -110,6 +111,7 @@ var stringToGenre = map[string]Genre{
"Jersey Club": JerseyClub,
"Vaporwave": Vaporwave,
"Moombahton": Moombahton,
"Dancehall": Dancehall
}

func ToGenre(s string) (Genre, bool) {
Expand Down
1 change: 1 addition & 0 deletions packages/discovery-provider/src/utils/hardcoded_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"Classical",
"Comedy",
"Country",
"Dancehall",
"Deep House",
"Devotional",
"Disco",
Expand Down
1 change: 1 addition & 0 deletions packages/libs/src/sdk/types/Genre.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export enum Genre {
LATIN = 'Latin',
LOFI = 'Lo-Fi',
HYPERPOP = 'Hyperpop',
DANCEHALL = 'Dancehall',

// Electronic Subgenres
TECHNO = 'Techno',
Expand Down