Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-router-v5-compat #8110

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Add react-router-v5-compat #8110

merged 3 commits into from
Apr 16, 2024

Conversation

dylanjeffers
Copy link
Contributor

Description

Adds react-router-v5-compat so we can transition to react-router-v6.

The main reason I'd like us to use this is so we can use some of the helpful hooks v6 comes with, like https://reactrouter.com/en/main/hooks/use-link-click-handler

Copy link

changeset-bot bot commented Apr 15, 2024

⚠️ No Changeset found

Latest commit: bf0c6ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/@apollo/protobufjs@1.2.7
  • Install script: postinstall
  • Source: node scripts/postinstall
  • orphan: npm/@apollo/protobufjs@1.2.7

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@apollo/protobufjs@1.2.7

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/add-react-router-compat-v5

@dylanjeffers dylanjeffers requested a review from DejayJD April 15, 2024 22:50
Copy link
Contributor

@sliptype sliptype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -171,6 +171,7 @@
"react-qr-code": "2.0.12",
"react-redux": "8.0.5",
"react-router-dom": "5.3.4",
"react-router-dom-v5-compat": "^6.22.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📍

@dylanjeffers dylanjeffers merged commit bfe784b into main Apr 16, 2024
2 of 5 checks passed
@dylanjeffers dylanjeffers deleted the add-react-router-compat-v5 branch April 16, 2024 16:55
audius-infra pushed a commit that referenced this pull request Apr 17, 2024
[eca7b4e] [PAY-2698] Add purchase button do album DMs (mobile) (#8134) Andrew Mendelsohn
[283163b] Upgrade native version to 1.1.94 (#8137) Dylan Jeffers
[863aed6] [INF-690] Delete sdk release job (#8130) Sebastian Klingler
[296c98c] [C-4279] Don't log not found errors to sentry (#8131) Andrew Mendelsohn
[e362ec7] [PAY-2617] Buy button for tracklist in albums (#8111) JD Francis
[b90390c] Convert tier badges back to png from svg [C-1337] (#8105) nicoback2
[5426358] Fixes close icon color on artist dashboard (#8133) Randy Schott
[7544a26] Support coinflow relay on client (#8088) Raymond Jacobson
[c54acb9] Fix premium album uploads (#8129) JD Francis
[fcf9757] [PAY-2697] Add purchase button to album DM unfurl (#8113) Andrew Mendelsohn
[aae5184] [INF-674] Add changesets (#8036) Sebastian Klingler
[5e1ceb4] [PAY-2661] Add collection card (#8100) Dylan Jeffers
[f3716b5] Fix nft undefined bug (#8121) Saliou Diallo
[bfe784b] Add react-router-v5-compat (#8110) Dylan Jeffers
[6cb5cbc] Fix collection screen types (#8124) Dylan Jeffers
[99bce8a] [PAY-2626] Warning modal when removing track from premium album (#8093) JD Francis
[a685aab] Fix metro support for @metaplex-foundation/umi (#8123) Sebastian Klingler
[c2d7d24] Make collectibles grid virtualized (#8009) Raymond Jacobson
[26f85aa] [C-4278] Fix native search collections (#8117) Dylan Jeffers
[05ad52b] Lint fixes for main (#8114) Andrew Mendelsohn
[32ad757] [C-4276] Add skeleton and artwork to harmony (#8108) Dylan Jeffers
[b54a2cd] [C-3949] Fix infinite library bug (#8107) Kyle Shanks
[1b400a4] ACDC tip notifs: encode hash id (#8101) alecsavvy
[e19037a] [PAY-2597] Test migration of a single endpoint from apiclient -> SDK (#8091) Randy Schott
[2da0d76] [PROTO-1515] Hide modification buttons for ddex tracks and albums (#8097) Theo Ilie
audius-infra pushed a commit that referenced this pull request Apr 18, 2024
[189834b] Revert version bump pt 2 sliptype
[33d1cb1] Revert version bump sliptype
[81e664d] v1.5.197 audius-infra
[5b08941] v1.5.196 audius-infra
[653fb4f] v1.5.195 audius-infra
[daa66c1] v1.5.194 audius-infra
[12c3493] v1.5.193 audius-infra
[4ea47f3] v1.5.192 audius-infra
[eae7c9c] v1.5.191 audius-infra
[6fcce3a] v1.5.190 audius-infra
[0e31639] v1.5.189 audius-infra
[bc8299f] v1.5.188 audius-infra
[33ad216] v1.5.187 audius-infra
[9d22f29] v1.5.186 audius-infra
[2d07d10] v1.5.185 audius-infra
[46745f7] v1.5.184 audius-infra
[7f643c6] v1.5.183 audius-infra
[1661499] v1.5.182 audius-infra
[96fc23d] v1.5.181 audius-infra
[e2b81f0] v1.5.180 audius-infra
[b3326ba] v1.5.179 audius-infra
[690168d] v1.5.178 audius-infra
[044f20f] v1.5.177 audius-infra
[6d9836b] v1.5.176 audius-infra
[fc6a40c] v1.5.175 audius-infra
[0ec4587] v1.5.174 audius-infra
[e8e9511] v1.5.173 audius-infra
[5f90c9a] v1.5.172 audius-infra
[781e5b4] v1.5.171 audius-infra
[6445c36] v1.5.170 audius-infra
[a65f44f] v1.5.169 audius-infra
[5f9927b] v1.5.168 audius-infra
[f6d8b3d] v1.5.167 audius-infra
[bfe984d] v1.5.166 audius-infra
[c9d6d6b] v1.5.165 audius-infra
[5ef3c96] v1.5.164 audius-infra
[8a84a3c] v1.5.163 audius-infra
[38d92b2] v1.5.162 audius-infra
[08e0825] v1.5.161 audius-infra
[9fb76bb] v1.5.160 audius-infra
[232e39c] v1.5.159 audius-infra
[45d3f65] v1.5.158 audius-infra
[cf1fe12] v1.5.157 audius-infra
[d9d1e5a] v1.5.156 audius-infra
[c42aae3] v1.5.155 audius-infra
[b11061c] v1.5.154 audius-infra
[e46e26a] v1.5.153 audius-infra
[2a9e030] v1.5.152 audius-infra
[38c9239] v1.5.151 audius-infra
[5c6a81b] v1.5.150 audius-infra
[f3b63bd] v1.5.149 audius-infra
[aa9380a] v1.5.148 audius-infra
[9926f1e] v1.5.147 audius-infra
[0a72ffa] v1.5.146 audius-infra
[e1d8de3] v1.5.145 audius-infra
[342a44c] v1.5.144 audius-infra
[97c0f34] v1.5.143 audius-infra
[d9ac347] v1.5.142 audius-infra
[eea4191] v1.5.141 audius-infra
[065ee82] v1.5.140 audius-infra
[8de980b] v1.5.139 audius-infra
[0afb9ce] v1.5.138 audius-infra
[7747f6b] v1.5.137 audius-infra
[8af8cca] v1.5.136 audius-infra
[85162c7] v1.5.135 audius-infra
[58f911b] v1.5.134 audius-infra
[a6d63bc] v1.5.133 audius-infra
[ba95ddc] v1.5.132 audius-infra
[c8b8ee2] v1.5.131 audius-infra
[08dce07] v1.5.130 audius-infra
[04037bd] v1.5.129 audius-infra
[149dd62] v1.5.128 audius-infra
[b67c590] v1.5.127 audius-infra
[2594c8b] v1.5.126 audius-infra
[cd4ceae] v1.5.125 audius-infra
[2a76eb2] v1.5.124 audius-infra
[eaa2e49] v1.5.123 audius-infra
[2748b4b] v1.5.122 audius-infra
[ffaae4c] v1.5.121 audius-infra
[3dcce94] v1.5.120 audius-infra
[57886e0] v1.5.119 audius-infra
[d2bb663] v1.5.118 audius-infra
[ef095cc] v1.5.117 audius-infra
[d30635a] v1.5.116 audius-infra
[d4dc291] v1.5.115 audius-infra
[0a96677] v1.5.114 audius-infra
[d63f1e2] v1.5.113 audius-infra
[3a34a50] v1.5.112 audius-infra
[054c0af] v1.5.111 audius-infra
[9c0436e] v1.5.110 audius-infra
[2bc96b7] v1.5.109 audius-infra
[38cffa9] v1.5.108 audius-infra
[e60e1fc] v1.5.107 audius-infra
[708b371] v1.5.106 audius-infra
[cda2846] v1.5.105 audius-infra
[8dc235e] v1.5.104 audius-infra
[cc20c06] v1.5.103 audius-infra
[3ca0423] v1.5.102 audius-infra
[d6f4993] v1.5.101 audius-infra
[88b1235] v1.5.100 audius-infra
[5f10b8f] v1.5.99 audius-infra
[9dd5cb1] v1.5.98 audius-infra
[140b332] v1.5.97 audius-infra
[4119352] v1.5.96 audius-infra
[93ee1be] v1.5.95 audius-infra
[e62a84d] v1.5.94 audius-infra
[aee1403] v1.5.93 audius-infra
[074e133] v1.5.92 audius-infra
[3ca80d4] v1.5.91 audius-infra
[ea47f05] v1.5.90 audius-infra
[56b92fd] v1.5.89 audius-infra
[bf933fb] v1.5.88 audius-infra
[54e2ab9] v1.5.87 audius-infra
[7635463] v1.5.86 audius-infra
[2aba710] v1.5.85 audius-infra
[67d7387] v1.5.84 audius-infra
[97dff7a] v1.5.83 audius-infra
[fb7629f] v1.5.82 audius-infra
[2c82d08] v1.5.81 audius-infra
[feb2503] v1.5.80 audius-infra
[8036d7b] v1.5.79 audius-infra
[7a78b19] v1.5.78 audius-infra
[4924c0f] v1.5.77 audius-infra
[eca7b4e] [PAY-2698] Add purchase button do album DMs (mobile) (#8134) Andrew Mendelsohn
[283163b] Upgrade native version to 1.1.94 (#8137) Dylan Jeffers
[863aed6] [INF-690] Delete sdk release job (#8130) Sebastian Klingler
[296c98c] [C-4279] Don't log not found errors to sentry (#8131) Andrew Mendelsohn
[e362ec7] [PAY-2617] Buy button for tracklist in albums (#8111) JD Francis
[b90390c] Convert tier badges back to png from svg [C-1337] (#8105) nicoback2
[5426358] Fixes close icon color on artist dashboard (#8133) Randy Schott
[7544a26] Support coinflow relay on client (#8088) Raymond Jacobson
[c54acb9] Fix premium album uploads (#8129) JD Francis
[fcf9757] [PAY-2697] Add purchase button to album DM unfurl (#8113) Andrew Mendelsohn
[aae5184] [INF-674] Add changesets (#8036) Sebastian Klingler
[5e1ceb4] [PAY-2661] Add collection card (#8100) Dylan Jeffers
[f3716b5] Fix nft undefined bug (#8121) Saliou Diallo
[bfe784b] Add react-router-v5-compat (#8110) Dylan Jeffers
[6cb5cbc] Fix collection screen types (#8124) Dylan Jeffers
[99bce8a] [PAY-2626] Warning modal when removing track from premium album (#8093) JD Francis
[a685aab] Fix metro support for @metaplex-foundation/umi (#8123) Sebastian Klingler
[c2d7d24] Make collectibles grid virtualized (#8009) Raymond Jacobson
[26f85aa] [C-4278] Fix native search collections (#8117) Dylan Jeffers
[05ad52b] Lint fixes for main (#8114) Andrew Mendelsohn
[32ad757] [C-4276] Add skeleton and artwork to harmony (#8108) Dylan Jeffers
[b54a2cd] [C-3949] Fix infinite library bug (#8107) Kyle Shanks
[1b400a4] ACDC tip notifs: encode hash id (#8101) alecsavvy
[e19037a] [PAY-2597] Test migration of a single endpoint from apiclient -> SDK (#8091) Randy Schott
[2da0d76] [PROTO-1515] Hide modification buttons for ddex tracks and albums (#8097) Theo Ilie
audius-infra pushed a commit that referenced this pull request Apr 20, 2024
[e74455d] [PAY-2688] Add prototype foundation for manager mode (#8154) Randy Schott
[6825c33] [PAY-2709, PAY-2710, PAY-2708] Various CollectionTile fixes (#8145) Andrew Mendelsohn
[7ad1e89] [C-4289] Make verify call lint instead of lint:fix (#8152) Sebastian Klingler
[d9420a9] [PAY-2666] Only show withdrawals on withdrawals tab (#8142) Marcus Pasell
[5249858] [ONC-74] Fix social account association (#8162) Marcus Pasell
[d66d393] Make another ddex delivery work (different URL) (#8161) Theo Ilie
[a50c773] [C-4247] Add cumulative rewards UI to web (#8143) Saliou Diallo
[5bce1aa] Add target for iOS privacy manifest (#8155) Sebastian Klingler
[d3510d1] Revert "Test figma code-connect (#8139)" (#8151) Dylan Jeffers
[8c91e4e] fix: Minor copy change in album upload flow (#8150) JD Francis
[bc84708] Test figma code-connect (#8139) Dylan Jeffers
[e6335ba] Allow audio/x-flac mime type (#8141) Steve Perkins
[e467cbe] [PAY-2695] Add hidden and premium collection card variants (#8135) Dylan Jeffers
[7182221] [PROTO-1726] Start simple entrypoint for distro (#8104) Raymond Jacobson
[eca7b4e] [PAY-2698] Add purchase button do album DMs (mobile) (#8134) Andrew Mendelsohn
[283163b] Upgrade native version to 1.1.94 (#8137) Dylan Jeffers
[863aed6] [INF-690] Delete sdk release job (#8130) Sebastian Klingler
[296c98c] [C-4279] Don't log not found errors to sentry (#8131) Andrew Mendelsohn
[e362ec7] [PAY-2617] Buy button for tracklist in albums (#8111) JD Francis
[b90390c] Convert tier badges back to png from svg [C-1337] (#8105) nicoback2
[5426358] Fixes close icon color on artist dashboard (#8133) Randy Schott
[7544a26] Support coinflow relay on client (#8088) Raymond Jacobson
[c54acb9] Fix premium album uploads (#8129) JD Francis
[fcf9757] [PAY-2697] Add purchase button to album DM unfurl (#8113) Andrew Mendelsohn
[aae5184] [INF-674] Add changesets (#8036) Sebastian Klingler
[5e1ceb4] [PAY-2661] Add collection card (#8100) Dylan Jeffers
[f3716b5] Fix nft undefined bug (#8121) Saliou Diallo
[bfe784b] Add react-router-v5-compat (#8110) Dylan Jeffers
[6cb5cbc] Fix collection screen types (#8124) Dylan Jeffers
[99bce8a] [PAY-2626] Warning modal when removing track from premium album (#8093) JD Francis
[a685aab] Fix metro support for @metaplex-foundation/umi (#8123) Sebastian Klingler
[c2d7d24] Make collectibles grid virtualized (#8009) Raymond Jacobson
[26f85aa] [C-4278] Fix native search collections (#8117) Dylan Jeffers
[05ad52b] Lint fixes for main (#8114) Andrew Mendelsohn
[32ad757] [C-4276] Add skeleton and artwork to harmony (#8108) Dylan Jeffers
[b54a2cd] [C-3949] Fix infinite library bug (#8107) Kyle Shanks
[1b400a4] ACDC tip notifs: encode hash id (#8101) alecsavvy
[e19037a] [PAY-2597] Test migration of a single endpoint from apiclient -> SDK (#8091) Randy Schott
[2da0d76] [PROTO-1515] Hide modification buttons for ddex tracks and albums (#8097) Theo Ilie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants