PROTO-1775: rm tcr env #8119
PROTO-1775: rm tcr env #8119
Conversation
|
|
|
||
| export const condition = (app: App<SharedData>): boolean => { | ||
| // "Fri 09:43:00 GMT-0600" | ||
| const { dateToRun } = app.viewAppData() | ||
| const date = Date.parse(dateToRun) | ||
| const timeToDisburse = moment(date) | ||
| const now = moment() | ||
| if (now.isSame(timeToDisburse, 'seconds')) return true | ||
| return false | ||
| } |
There was a problem hiding this comment.
I'm guessing this is just unused cruft
There was a problem hiding this comment.
yes, this used to rely on the date env var i removed
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 688750 | Triggered | Generic High Entropy Secret | b30997e | packages/mobile/src/env/env.prod.ts | View secret |
| 1606949 | Triggered | Generic High Entropy Secret | b30997e | packages/mobile/src/env/env.prod.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
[5ad42e0] Fix solana relay cache key (#8219) Marcus Pasell [deb3f2a] [PAY-2747] Fix attestation decoding and add Secp256k1Program utils (#8210) Marcus Pasell [342d610] [PAY-2749] Use ownerWallet instead of delegateOwnerWallet for uniquely owned endpoints in SDK (#8217) Marcus Pasell [3cfc215] [PAY-2550] Add images to apps (#8196) Raymond Jacobson [a9e0313] Combine ddex crawler+parser, and add dev cmd (#8203) Theo Ilie [2789c96] PROTO-1775: rm tcr env (#8119) alecsavvy [79c4acc] [C-3921] Stop sending signature headers as params (#7774) Raymond Jacobson
Description
This removes the tcr.env from the rewards bot so it can use override.env instead. This should make it compatible with audius-d. This also adds a tcr prefix to all env vars so they can be easily identified in the override.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.