DDEX separate release date and validity start date #8146
Conversation
…back to validity start. Deduce album validity start if no deal is provided for the album. TODO publisher polls max(validity start, release date)
|
michellebrier
changed the title
There was a problem hiding this comment.
this looks great! could you update the Notion doc and/or follow up with @samgutentag to make sure the docs reflect this?
| if !parsedReleaseElem.ReleaseDate.IsZero() { | ||
| track.ReleaseDate = parsedReleaseElem.ReleaseDate | ||
| } | ||
| track.ReleaseDate = parsedReleaseElem.ReleaseDate |
There was a problem hiding this comment.
so there's no chance it would've been non-zero before and this sets it to the zero Time? i thought maybe this check was there because the ReleaseDate was already set
There was a problem hiding this comment.
track.ReleaseDate would be from the sound recording if I understand this correctly, and I don't see any release date logic when we parse out the sound recording for a track, so it shouldn't be overriding anything, right?
There was a problem hiding this comment.
hm yeah looks like it would always be empty so i'm not sure why it was there. seems okay as is then
* origin/main: Audius Client (Web and Mobile) v1.5.77 Add ddex s3 sync script (#8175) Improve DDEX/aws interaction (#8167) Fix changeset github action (#8172) Fix storage progress bar (#8169) [INF-388] Improve protocol GH releases (#8159) [PAY-2688] Add prototype foundation for manager mode (#8154) DDEX separate release date and validity start date (#8146) [PAY-2709, PAY-2710, PAY-2708] Various CollectionTile fixes (#8145) [C-4289] Make verify call lint instead of lint:fix (#8152) [PAY-2666] Only show withdrawals on withdrawals tab (#8142) [ONC-74] Fix social account association (#8162) [PAY-2692] Purchase/sale push+email notification album support (#8158) Don't allow creating developer app with user wallet as address [C-4041 (#8165) Update cooldown days in response (#8160) Bump version to 0.6.85
[4076554] Add ddex s3 sync script (#8175) Raymond Jacobson [ee55257] Improve DDEX/aws interaction (#8167) Raymond Jacobson [225915c] Fix storage progress bar (#8169) Marcus Pasell [8e8e083] DDEX separate release date and validity start date (#8146) Michelle Brier [7ad1e89] [C-4289] Make verify call lint instead of lint:fix (#8152) Sebastian Klingler [d9420a9] [PAY-2666] Only show withdrawals on withdrawals tab (#8142) Marcus Pasell [5249858] [ONC-74] Fix social account association (#8162) Marcus Pasell [78db43e] [PAY-2692] Purchase/sale push+email notification album support (#8158) Reed [40379a6] Don't allow creating developer app with user wallet as address [C-4041 (#8165) nicoback2 [0777866] Update cooldown days in response (#8160) Saliou Diallo
Description
Parse and persist release date (from the release details) and validity start date (from the corr. deal) separately. Poll for
max(release_date, validity_start_date) >= current_datein the publisher. If no<ReleaseDate>or<GlobalOriginalReleaseDate>is provided,release_dategets set to the validity start date, which is required. Therelease_dateis what gets displayed in the UI.How Has This Been Tested?
e2e tests, upload an xml locally