Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROTO-1767: rm old reactions columns and modify indexers to not use it #8188

Merged
merged 9 commits into from
May 13, 2024

Conversation

alecsavvy
Copy link
Contributor

Description

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Copy link

changeset-bot bot commented Apr 22, 2024

⚠️ No Changeset found

Latest commit: 0bf64f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@rickyrombo rickyrombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add the ACDC block for going forward? eg to help with reverts maybe w/ cascade delete?

@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 30, 2024
@alecsavvy alecsavvy self-assigned this Apr 30, 2024
Copy link

gitguardian bot commented May 13, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9349019 Triggered Generic High Entropy Secret be88ee8 dev-tools/config.json View secret
9349019 Triggered Generic High Entropy Secret 11d9f9c packages/ddex/.env.stage View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@alecsavvy alecsavvy merged commit a8f42e7 into main May 13, 2024
11 of 12 checks passed
@alecsavvy alecsavvy deleted the as/proto-1767-tip-reactions-cleanup branch May 13, 2024 21:16
audius-infra pushed a commit that referenced this pull request May 14, 2024
[f9c7705] [PROTO-1813] Add geo to purchases (#8424) Raymond Jacobson
[97d9bea] Remove idempotent check in pg migrate test (#8453) Isaac Solo
[a8f42e7] PROTO-1767: rm old reactions columns and modify indexers to not use it (#8188) alecsavvy
[f523512] No math.abs function in python (#8448) Danny
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants