Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[⚠️] Clean up discovery node build artifacts and URSM code #8234

Merged
merged 3 commits into from
Apr 29, 2024
Merged

[⚠️] Clean up discovery node build artifacts and URSM code #8234

merged 3 commits into from
Apr 29, 2024

Conversation

raymondjacobson
Copy link
Member

@raymondjacobson raymondjacobson commented Apr 25, 2024 •
edited
Loading

Description

  • Remove unused alembic dir
  • Remove unused prometheus & loggly args
  • Remove inheritance from audius/contracts base image. The only ABI we need is EntityManager and that is already checked into code
  • Remove user replica set manager code. It was the only reason there was something besides EntityManager's ABI in build/contracts.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

audius-compose up
audius-cmd create-user freddie_mercury

and CI

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b640183

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@raymondjacobson raymondjacobson changed the title Clean up discovery node build artifacts [⚠️] Clean up discovery node build artifacts and URSM code Apr 25, 2024
alecsavvy
alecsavvy reviewed Apr 29, 2024
View reviewed changes
packages/discovery-provider/Dockerfile.dev
@@ -1,13 +1,9 @@
# Pretty much the same as the Dockerfile.prod but assumes the whole
# discovery-provider package is a mounted volume instead of copying everything.
FROM audius/contracts:1.0.0 AS contracts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

rickyrombo
rickyrombo approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@rickyrombo rickyrombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesss death to replica sets!

@raymondjacobson raymondjacobson merged commit bd2fbc3 into main Apr 29, 2024
11 checks passed
@raymondjacobson raymondjacobson deleted the rj-clean-up-dn branch April 29, 2024 23:47
@raymondjacobson raymondjacobson mentioned this pull request Apr 30, 2024
Merged
audius-infra pushed a commit that referenced this pull request Apr 30, 2024
Audius Protocol v0.6.92
e62a110 
[bd2fbc3] [⚠️] Clean up discovery node build artifacts and URSM code (#8234) Raymond Jacobson
[df0349a] [PAY-2761] Add managed users endpoints (#8238) Randy Schott
[ca8133d] [PROTO-1789] Fix up minor entrypoint issues and deploy (#8252) Raymond Jacobson
[7e4ec20] Add cloudflare ip check fix (#8253) Raymond Jacobson
[321ebf6] [ONC-83] Add stage-only migration to fix indexing the sepolia chain (#8257) Saliou Diallo
sliptype added a commit that referenced this pull request May 2, 2024
@sliptype
Revert "[⚠️] Clean up discovery node build artifacts and URSM code (#…
3c6d4f4 
…8234)"

This reverts commit bd2fbc3.
sliptype added a commit that referenced this pull request May 2, 2024
@sliptype
Reapply "[⚠️] Clean up discovery node build artifacts and URSM code (#…
fda21ff 
…8234)"

This reverts commit 3c6d4f4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecsavvy alecsavvy alecsavvy approved these changes

@theoilie theoilie theoilie approved these changes

@rickyrombo rickyrombo rickyrombo approved these changes

@phelpsdb phelpsdb phelpsdb approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@raymondjacobson @phelpsdb @rickyrombo @theoilie @alecsavvy