Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAY-2810] Purchase/Sale email fix text for albums #8310

Merged
merged 1 commit into from
May 2, 2024
Merged

[PAY-2810] Purchase/Sale email fix text for albums #8310

merged 1 commit into from
May 2, 2024

Conversation

dharit-tan
Copy link
Contributor

Description

Small copy + formatting changes for purchase + sale emails

How Has This Been Tested?

Not tested - test on stage

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 2, 2024

⚠️ No Changeset found

Latest commit: d55a46f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

amendelsohn
amendelsohn approved these changes May 2, 2024
View reviewed changes
...ges/discovery-provider/plugins/notifications/src/email/notifications/preRendered/purchase.ts
@@ -1,5 +1,8 @@
import { capitalize } from 'lodash'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking since this is the only one. Are we allowed to import packages here?

I assume it's fine cause this is just a discovery-provider plugin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is just a ts file so i would assume it's ok..

Copy link
Member

@raymondjacobson raymondjacobson May 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine if it's in the package.json

@dharit-tan dharit-tan enabled auto-merge (squash) May 2, 2024 03:26
@dharit-tan dharit-tan merged commit 4abc13b into main May 2, 2024
9 of 11 checks passed
@dharit-tan dharit-tan deleted the rt-email branch May 2, 2024 03:41
audius-infra pushed a commit that referenced this pull request May 2, 2024
Audius Protocol v0.6.94
7abff7e 
[4abc13b] [PAY-2810] Purchase/Sale email fix text for albums (#8310) Reed
[992cf7d] [PAY-2764] Implement DeveloperApp Update entity manager action (#8254) Raymond Jacobson
[621c3ee] Convert swagger.json to OAS 3.0 before generating SDK types (#8274) Marcus Pasell
[7e0aa7e] [PAY-2823] Edit Album access control fixes (#8298) Andrew Mendelsohn
[8f7394c] ddex: parse contributors (#8267) Steve Perkins
[8520ee6] [PAY-2796] Fix extra notifications on track removal from purchased album (#8282) Reed
schottra added a commit that referenced this pull request May 2, 2024
@schottra
Merge remote-tracking branch 'origin/main' into pay-2722-account-swit…
0b82657 
…cher

* origin/main: (47 commits)
  [PAY-2728] Implement edit app flow (#8256)
  Audius Protocol v0.6.94
  [C-4288] Migrate to new cards in profile, search, and library (#8300)
  Upgrade dapp-store to 0.8.1 (#8311)
  [PAY-2794] Use UserLink for purchases/sales tables (#8306)
  [PAY-2810] Purchase/Sale email fix text for albums (#8310)
  [PAY-2764] Implement DeveloperApp Update entity manager action (#8254)
  [PAY-2772] Fix collection description text size (#8309)
  [PAY-2822] Convert LockedContentDetailsTile to Harmony (#8308)
  [PAY-2781] Poll for track access on album purchase (#8296)
  Convert swagger.json to OAS 3.0 before generating SDK types (#8274)
  Retrigger logic for android notification permissions post-manifest fix (#8305)
  [PAY-2815] Show unlocked icon if dm content is purchased (#8303)
  [PAY-2779] Fix validation for albumTrackPrice (#8302)
  Fix EditCollection playwright test (#8304)
  [PAY-2823] Edit Album access control fixes (#8298)
  [QA-971] Fix smart collections (#8299)
  [PAY-2791] Show only own albums in artist dashboard (#8297)
  [Web] [Harmony] Add accounts managing you modal [C-4295] [C-4292] (#8258)
  [C-4238, C-4318] Add ssr small bundle flow for mobile track page (#8293)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyrombo rickyrombo rickyrombo approved these changes

@raymondjacobson raymondjacobson raymondjacobson approved these changes

@amendelsohn amendelsohn amendelsohn approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dharit-tan @amendelsohn @raymondjacobson @rickyrombo