Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddex: handle updates and deletes #8327

Merged
merged 6 commits into from
May 6, 2024
Merged

ddex: handle updates and deletes #8327

merged 6 commits into from
May 6, 2024

Conversation

stereosteve
Copy link
Contributor

@stereosteve stereosteve commented May 3, 2024 •
edited
Loading

Description

  • parse xml switches on root xml node name to call either parsePurgeXml or parseReleaseXml
  • adds a status for DeletePending and publisher will use that to perform deletes
  • adds messageTimestamp to releases table... upsert will only update releases row to PublishPending if timestamp is newer (or timestamp is same and json changed)
  • tests simulate state transitions

inspired by: #8251

stereosteve added 2 commits May 3, 2024 09:45
@stereosteve
improve state tracking for updates + deletes
562a94c
@stereosteve
use messageTimestamp to track updates
6d13719 
Only update releases row if xml messageTimestamp is newer.
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bc1883b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@stereosteve stereosteve changed the title Ddex update delete ddex: handle updates and deletes May 3, 2024
@stereosteve stereosteve requested a review from michellebrier May 3, 2024 15:32
@pull-request-size pull-request-size bot added size/XL and removed size/L labels May 3, 2024
michellebrier
michellebrier approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@michellebrier michellebrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. still need to support 1. takedowns indicated by a NewReleaseMessage with no deal, and 2. updates without resources if the resource was sent prior

@stereosteve stereosteve merged commit 2eec73b into main May 6, 2024
8 checks passed
@stereosteve stereosteve deleted the ddex-update-delete branch May 6, 2024 14:57
audius-infra pushed a commit that referenced this pull request May 6, 2024
Audius Protocol v0.6.96
ec34ea0 
[2eec73b] ddex: handle updates and deletes (#8327) Steve Perkins
[9f44712] Reapply "Convert swagger.json to OAS 3.0 before generating SDK types (#8274)" (#8324) (#8344) Marcus Pasell
[f005b25] [PAY-2860] SDK Services Config - Configure SDK using environment (#8329) Marcus Pasell
[f43790f] Add crm plugin (#8317) Raymond Jacobson
schottra added a commit that referenced this pull request May 6, 2024
@schottra
Merge remote-tracking branch 'origin/main' into pay-2722-account-swit…
127c722 
…cher

* origin/main: (33 commits)
  Audius Protocol v0.6.96
  ddex: handle updates and deletes (#8327)
  Audius Client (Web and Mobile) v1.5.79
  Reapply "Convert swagger.json to OAS 3.0 before generating SDK types (#8274)" (#8324) (#8344)
  Fix issues with text-link variant (#8343)
  [PAY-2860] SDK Services Config - Configure SDK using environment (#8329)
  Disable add to playlist for prem tracks if not purchased (#8336)
  [C-4335] Migrate all user and collection cards (#8338)
  Fix crm CI (#8342)
  Add CI for crm plugin (#8335)
  [QA-1241] Fix hidden track add to playlist allowing non hidden items (#8340)
  [QA-956] Add deleted tile for tracks/albums/playlists (#8333)
  Add error message to upload flow (#8334)
  [PROTO-1706] fixups (#8337)
  Add crm plugin (#8317)
  [PROTO-1706] - Audius-d Node Documentation (#8325)
  [QA-957] Fix android overflowing text on access & sale modal (#8313)
  [PAY-2812] Change spend to earn challenge copy (#8332)
  Close modal on done (#8331)
  [PAY-2861] CollectionCard fixes (#8330)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michellebrier michellebrier michellebrier approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stereosteve @michellebrier