[C-4277] Prevent empty albums in feed #8444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
raymondjacobson
approved these changes
May 11, 2024
| @@ -241,6 +241,9 @@ services: | |||
| audius_elasticsearch_url: 'http://discovery-provider-elasticsearch:9200' | |||
| volumes: | |||
| - ${PROJECT_ROOT}/packages/discovery-provider:/audius-discovery-provider | |||
| - ${PROJECT_ROOT}/packages/es-indexer:/app/packages/discovery-provider/es-indexer | |||
| - ${PROJECT_ROOT}/node_modules:/app/node_modules | |||
There was a problem hiding this comment.
wow local modules work? sometimes they don't b/c of arch
There was a problem hiding this comment.
oh interesting, yeah it worked in this case for running the tests
| {"term": {"track_ids": False}}, | ||
| {"script": { | ||
| "script": { | ||
| "source": "doc[''].size() > 0" |
audius-infra
pushed a commit
that referenced
this pull request
May 20, 2024
[981954f] ddex yaml time (#8515) Steve Perkins [692e5cb] [PROTO-1690] Elasticsearch cluster health check (#8548) Danny [bebe484] mediorum: in memory image cache (#8544) Steve Perkins [5a7f3e3] Tighter over-replication threshold (#8539) Steve Perkins [fdc248d] [C-4277] Prevent empty albums in feed (#8444) Dylan Jeffers [c7ec583] Local development fixes (lint, compose, deps) (#8486) Danny [ba67563] Fix CRM log message (#8507) Raymond Jacobson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where albums with no tracks and albums with all hidden/deleted tracks appear on the feed.
How Has This Been Tested?
Reintroduced and added new feed_es tests