Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediorum: ignore reachability in repair.go #8586

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

stereosteve
Copy link
Contributor

Assume nodes work even if not reachable.

Copy link

changeset-bot bot commented May 22, 2024

⚠️ No Changeset found

Latest commit: 3adc5e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand how this change will help, but it is potentially dangerous if those other nodes don't have the content? Let's chat today about it!

@stereosteve stereosteve merged commit 3721596 into main May 22, 2024
11 checks passed
@stereosteve stereosteve deleted the repair-ignore-reachablity branch May 22, 2024 17:46
schottra added a commit that referenced this pull request May 22, 2024
…cher-cleanup

* origin/main: (23 commits)
  Add cascade delete on album price history (#8588)
  mediorum: ignore reachability in repair.go (#8586)
  ddex: remove docker user (#8572)
  Audius Protocol v0.6.109
  [PAY-2755] Add solana-relay logs to Axiom (#8585)
  [PAY-2691] Integrate purchase track in SDK (#8409)
  [PAY-3045] Show play button if user has access to any of collection's contents (#8578)
  Close purchase/sale details modal on user click (#8582)
  Add DB triggers for manager mode notifications [PAY-2828] (#8573)
  Increase replication cleanup in mediorum (#8583)
  Remove api_key query param to recover signature correctly (#8579)
  Option 2 for dealing with remove/approve manager errors: don't do anything [C-4331] (#8483)
  [PAY-2994] Fix oneOf model Typescript generation in SDK (#8575)
  ddex: Rescan past xml after user upsert (#8576)
  Remove lossless tag (#8577)
  [C-4529] Migrate pill to harmony (#8563)
  Fix lossless validation (#8574)
  [Web] Various manager mode flow cleanup tasks [C-4332] [PAY-2831] [C-4331] (#8481)
  [QA-1300] Fix verified icon sizing (#8552)
  [PAY-2873] Add forceRefetch flag to collection fetching on web (#8561)
  ...
audius-infra pushed a commit that referenced this pull request May 23, 2024
[c474195] [Discovery] Fix flaky test (#8596) nicoback2
[4e3dc09] [QA-1313] Fix purchase/sale email random null (#8591) Reed
[276f714] [PAY-2912] Add purchase album support to SDK (#8593) Marcus Pasell
[f20d3dd] [PAY-3024] Skip onFavorite notifications for purchased content (#8580) Andrew Mendelsohn
[117067d] [PROTO-1834] Enabling disallow third party streaming from client (#8587) Isaac Solo
[d5ce34d] [PAY-2947] Implement spl_usdc_payout_wallet user entity manager actions (#8479) Raymond Jacobson
[9590688] Add cascade delete on album price history (#8588) Isaac Solo
[3721596] mediorum: ignore reachability in repair.go (#8586) Steve Perkins
[8a1f226] ddex: remove docker user (#8572) Steve Perkins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants