Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Third Party Wallet Support [PAY-2949][PAY-2948][PAY-2950] #8611
⚠️ Third Party Wallet Support [PAY-2949][PAY-2948][PAY-2950] #8611
Changes from 13 commits
17030db
acb8940
4573ceb
0bd1bfd
f4bd876
547db11
fc801d0
679828d
cb33ca6
d5ad9f8
7023105
f257d77
655c97b
b7a656d
fd7dab1
4c0e872
f3fc6e4
2a2cae0
05724d9
42a0644
d0c93fd
b1a3a3c
3fb8027
7194819
1b99430
0356fd7
88eef78
364df48
c4d9cda
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have non object things still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is really just
IS NOT NULL
i guess, but with a tighter safeguard for after this conversion happens to not do it againThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, what's this fixing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a mypy issue iirc