Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAY-2714] track_added_to_purchased_album noti test #8616

Merged
merged 1 commit into from
May 25, 2024
Merged

[PAY-2714] track_added_to_purchased_album noti test #8616

merged 1 commit into from
May 25, 2024

Conversation

dharit-tan
Copy link
Contributor

Description

Add a test for the new notification type. Used test_usdc_purchase_notification as a template + renamed a misnamed test there.

How Has This Been Tested?

Test passes locally.

@dharit-tan dharit-tan requested review from amendelsohn, a team and schottra and removed request for a team May 24, 2024 19:49
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 24, 2024

⚠️ No Changeset found

Latest commit: 29fdeee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

amendelsohn
amendelsohn reviewed May 24, 2024
View reviewed changes
packages/discovery-provider/integration_tests/utils.py
stream_conditions=playlist_meta.get("stream_conditions", None),
)
session.add(playlist)
for i, playlist_track_meta in enumerate(playlist_tracks):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be populating this from the playlist_contents fields in the playlists instead? seems annoying to have to manually populate both tables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm potentially... but i feel like there might be cases where we'd want separate control. kinda in favor of just sticking to existing patterns? most tests will explicitly use or not use playlist_tracks i think.

@dharit-tan dharit-tan enabled auto-merge (squash) May 24, 2024 20:10
@dharit-tan dharit-tan disabled auto-merge May 25, 2024 04:15
@dharit-tan dharit-tan merged commit 8289783 into main May 25, 2024
11 of 12 checks passed
@dharit-tan dharit-tan deleted the rt-noti-test branch May 25, 2024 04:15
audius-infra pushed a commit that referenced this pull request May 27, 2024
Audius Protocol v0.6.112
4089590 
[8289783] [PAY-2714] track_added_to_purchased_album noti test (#8616) Reed
schottra added a commit that referenced this pull request May 28, 2024
@schottra
Merge remote-tracking branch 'origin/main' into fix-user-override
5d9081a 
* origin/main:
  Audius Protocol v0.6.112
  Audius Client (Web and Mobile) v1.5.82
  [PAY-2714] track_added_to_purchased_album noti test (#8616)
  [C-3681] Add native mobile buffer (#8606)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyrombo rickyrombo rickyrombo approved these changes

@amendelsohn amendelsohn amendelsohn approved these changes

@schottra schottra Awaiting requested review from schottra schottra was automatically assigned from AudiusProject/monetization

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dharit-tan @amendelsohn @rickyrombo