-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C-4237] Fix create notification when track is published #8634
Conversation
This reverts commit 055ee92.
|
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
688750 | Triggered | Generic High Entropy Secret | baa3fa9 | packages/web/src/services/env/env.stage.ts | View secret |
688750 | Triggered | Generic High Entropy Secret | baa3fa9 | packages/mobile/src/env/env.stage.ts | View secret |
688750 | Triggered | Generic High Entropy Secret | baa3fa9 | packages/mobile/src/env/env.prod.ts | View secret |
688750 | Triggered | Generic High Entropy Secret | baa3fa9 | packages/web/src/services/env/env.prod.ts | View secret |
1606949 | Triggered | Generic High Entropy Secret | baa3fa9 | packages/web/src/services/env/env.prod.ts | View secret |
1606949 | Triggered | Generic High Entropy Secret | baa3fa9 | packages/mobile/src/env/env.prod.ts | View secret |
1606950 | Triggered | Generic High Entropy Secret | baa3fa9 | packages/libs/src/sdk/config/production.ts | View secret |
1606950 | Triggered | Generic High Entropy Secret | baa3fa9 | packages/libs/src/sdk/scripts/generateServicesConfig.ts | View secret |
7150224 | Triggered | Generic High Entropy Secret | baa3fa9 | packages/libs/src/sdk/scripts/generateServicesConfig.ts | View secret |
7150224 | Triggered | Generic High Entropy Secret | baa3fa9 | packages/libs/src/sdk/config/staging.ts | View secret |
10622416 | Triggered | Generic High Entropy Secret | baa3fa9 | packages/libs/src/sdk/config/production.ts | View secret |
10622416 | Triggered | Generic High Entropy Secret | baa3fa9 | packages/libs/src/sdk/scripts/generateServicesConfig.ts | View secret |
10622416 | Triggered | Generic High Entropy Secret | baa3fa9 | packages/libs/src/sdk/scripts/generateServicesConfig.ts | View secret |
10622416 | Triggered | Generic High Entropy Secret | baa3fa9 | packages/libs/src/sdk/config/staging.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
packages/discovery-provider/integration_tests/notifications/test_track.py
Outdated
Show resolved
Hide resolved
3cce2de
to
26eacfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
…-pay-and-earn * origin/main: Create Apps Dev Docs link updated (#8492) Fix typos (#8620) Fix album tile playback (#8637) [C-4451] Add feature flag and switch for edit track redesign (#8639) Fix copy (#8640) Add DPID and party name info to distro docs (#8638) [C-4237] Fix create notification when track is published (#8634) Fix chromecast support, again (#8636) Audius Protocol v0.6.114⚠️ [C-4416, C-4418, C-4419 C-4322] Fast SSR (#8603) PROTO-1846: add discovery listens status to healthz (#8631) [QA-1226] Add missing tier info (#8635) Fix first track in lineup playback issue (#8632) [QA-1321] Show spinner for audio balance if rpc call fails (#8630) [C-4417] Add a buffering metric (#8619) Replace structuredClone with cloneDeep for native compat (#8633) [PROTO-1802] Add DDEX entrypoint UI deep link (#8374)
Description
When a track is published from
is_unlisted
false to true, a create notification should be sent to all subscribers. This includes publishing a track in a scheduled release.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Updated existing integration tests.
Ran client against a sandbox with this change and confirmed the create notification was made.