Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C-4237] Fix create notification when track is published #8634

Merged
merged 6 commits into from
May 29, 2024

Conversation

isaacsolo
Copy link
Contributor

@isaacsolo isaacsolo commented May 28, 2024

Description

When a track is published from is_unlisted false to true, a create notification should be sent to all subscribers. This includes publishing a track in a scheduled release.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Updated existing integration tests.
Ran client against a sandbox with this change and confirmed the create notification was made.

Copy link

changeset-bot bot commented May 28, 2024

⚠️ No Changeset found

Latest commit: 26eacfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

gitguardian bot commented May 28, 2024

⚠️ GitGuardian has uncovered 14 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
688750 Triggered Generic High Entropy Secret baa3fa9 packages/web/src/services/env/env.stage.ts View secret
688750 Triggered Generic High Entropy Secret baa3fa9 packages/mobile/src/env/env.stage.ts View secret
688750 Triggered Generic High Entropy Secret baa3fa9 packages/mobile/src/env/env.prod.ts View secret
688750 Triggered Generic High Entropy Secret baa3fa9 packages/web/src/services/env/env.prod.ts View secret
1606949 Triggered Generic High Entropy Secret baa3fa9 packages/web/src/services/env/env.prod.ts View secret
1606949 Triggered Generic High Entropy Secret baa3fa9 packages/mobile/src/env/env.prod.ts View secret
1606950 Triggered Generic High Entropy Secret baa3fa9 packages/libs/src/sdk/config/production.ts View secret
1606950 Triggered Generic High Entropy Secret baa3fa9 packages/libs/src/sdk/scripts/generateServicesConfig.ts View secret
7150224 Triggered Generic High Entropy Secret baa3fa9 packages/libs/src/sdk/scripts/generateServicesConfig.ts View secret
7150224 Triggered Generic High Entropy Secret baa3fa9 packages/libs/src/sdk/config/staging.ts View secret
10622416 Triggered Generic High Entropy Secret baa3fa9 packages/libs/src/sdk/config/production.ts View secret
10622416 Triggered Generic High Entropy Secret baa3fa9 packages/libs/src/sdk/scripts/generateServicesConfig.ts View secret
10622416 Triggered Generic High Entropy Secret baa3fa9 packages/libs/src/sdk/scripts/generateServicesConfig.ts View secret
10622416 Triggered Generic High Entropy Secret baa3fa9 packages/libs/src/sdk/config/staging.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@isaacsolo isaacsolo requested review from phelpsdb and stereosteve May 28, 2024 22:58
@isaacsolo isaacsolo changed the title Fix create notification when track is published [C-4237] Fix create notification when track is published May 29, 2024
@isaacsolo isaacsolo force-pushed the is-fix-publish-track-notif branch from 3cce2de to 26eacfa Compare May 29, 2024 16:57
@isaacsolo isaacsolo enabled auto-merge (squash) May 29, 2024 17:39
Copy link
Contributor

@stereosteve stereosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@isaacsolo isaacsolo disabled auto-merge May 29, 2024 17:59
@isaacsolo isaacsolo merged commit 23e0e27 into main May 29, 2024
11 of 12 checks passed
@isaacsolo isaacsolo deleted the is-fix-publish-track-notif branch May 29, 2024 17:59
schottra added a commit that referenced this pull request May 29, 2024
…-pay-and-earn

* origin/main:
  Create Apps Dev Docs link updated (#8492)
  Fix typos (#8620)
  Fix album tile playback (#8637)
  [C-4451] Add feature flag and switch for edit track redesign (#8639)
  Fix copy (#8640)
  Add DPID and party name info to distro docs (#8638)
  [C-4237] Fix create notification when track is published (#8634)
  Fix chromecast support, again (#8636)
  Audius Protocol v0.6.114
  ⚠️ [C-4416, C-4418, C-4419 C-4322] Fast SSR (#8603)
  PROTO-1846: add discovery listens status to healthz (#8631)
  [QA-1226] Add missing tier info (#8635)
  Fix first track in lineup playback issue (#8632)
  [QA-1321] Show spinner for audio balance if rpc call fails (#8630)
  [C-4417] Add a buffering metric (#8619)
  Replace structuredClone with cloneDeep for native compat (#8633)
  [PROTO-1802] Add DDEX entrypoint UI deep link (#8374)
audius-infra pushed a commit that referenced this pull request May 30, 2024
[23e0e27] [C-4237] Fix create notification when track is published (#8634) Isaac Solo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants