Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore playwright test failures until flakiness is resolved #8673

Merged
merged 1 commit into from
May 31, 2024

Conversation

phelpsdb
Copy link
Contributor

Description

Playwright tests have been flaky and negatively impacted the reliability of our integration test. This PR will prevent errors from failing the workflow until the flakiness is resolved.

How Has This Been Tested?

CI

Copy link

changeset-bot bot commented May 31, 2024

⚠️ No Changeset found

Latest commit: bd9215e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/phelpsdb-playwright-nostatus

@phelpsdb phelpsdb marked this pull request as ready for review May 31, 2024 18:33
@phelpsdb phelpsdb requested a review from sliptype May 31, 2024 18:33
Copy link
Contributor

@sliptype sliptype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@phelpsdb phelpsdb merged commit df82d96 into main May 31, 2024
43 of 47 checks passed
@phelpsdb phelpsdb deleted the phelpsdb-playwright-nostatus branch May 31, 2024 18:37
schottra added a commit that referenced this pull request Jun 3, 2024
…ixes

* origin/main:
  Fix SSR trying to load something when going to search route (#8688)
  [QA-1341] Fix track-tile skeleton (#8683)
  Flip email deliverable boolean (#8685)
  Audius Protocol v0.6.117
  Fix purchasing albums w/ SDK (#8682)
  Audius Client (Web and Mobile) v1.5.83
  [C-4447] SSR cleanup (#8679)
  [C-4329] Update profile page sub routes (#8681)
  admonition css link color fixes (#8680)
  [INF-488] verify sdk in ci and git hooks (#8678)
  Update maxSize for bundle size check (#8677)
  Fix sdk types (#8676)
  Fix trending POA Block (#8675)
  Don't show preview for mobile mixed albums (#8674)
  Version Packages (#8661)
  Ignore playwright test failures until flakiness is resolved (#8673)
  fix libkeyfinder dependencies again (#8670)
  [DOCS] - audius-d storage config guides (#8645)
  Fix mobile playback not working (#8665)
  Audius Protocol v0.6.116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants