Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C-4455] Update otp email #8727

Merged
merged 6 commits into from
Jun 6, 2024
Merged

[C-4455] Update otp email #8727

merged 6 commits into from
Jun 6, 2024

Conversation

isaacsolo
Copy link
Contributor

Description

Update otp email to match new design system.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Ran on stage

Copy link

changeset-bot bot commented Jun 5, 2024

⚠️ No Changeset found

Latest commit: fb7abdb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@isaacsolo isaacsolo requested a review from DejayJD June 5, 2024 16:09
@isaacsolo isaacsolo changed the title Update otp email [C-4455] Update otp email Jun 5, 2024
@isaacsolo isaacsolo closed this Jun 6, 2024
@isaacsolo isaacsolo force-pushed the is-update-otp-email branch from e134815 to 1da19d3 Compare June 6, 2024 14:18
@isaacsolo isaacsolo deleted the is-update-otp-email branch June 6, 2024 14:19
@isaacsolo isaacsolo restored the is-update-otp-email branch June 6, 2024 14:19
@isaacsolo isaacsolo reopened this Jun 6, 2024
<!--
<![endif]-->
</div>
const getOtpEmail = ({ otp, expire, copyrightYear }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How plug-n-play was this from Figma? Did you just have to interpolate the values, and the rest was copy pasta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly copy and paste, some small things we need to look out for in general like the copyright year, some links should open in a new tab, some inline links are missing in the template

@isaacsolo isaacsolo enabled auto-merge (squash) June 6, 2024 18:43
@isaacsolo isaacsolo merged commit ed8febd into main Jun 6, 2024
11 checks passed
@isaacsolo isaacsolo deleted the is-update-otp-email branch June 6, 2024 18:56
audius-infra pushed a commit that referenced this pull request Jun 7, 2024
[fa19828] [PAY-3091] Move social handles out of identity into dn via entity manager (#8728) Saliou Diallo
[fe60b30] Fix dupe swagger id (#8745) JD Francis
[ed8febd] [C-4455] Update otp email (#8727) Isaac Solo
[8496557] [C-4263] Add OptionsFilterButton and implement more search filters (#8737) Sebastian Klingler
[49b5a56] [C-4660] POC: Pre-fetch CN stream urls (no /stream redirects) (#8741) JD Francis
[dfb04fd] on call: fix search on stage (#8743) alecsavvy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants