Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to ensure updating playlist_id fails #8736

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Add test to ensure updating playlist_id fails #8736

merged 1 commit into from
Jun 5, 2024

Conversation

dharit-tan
Copy link
Contributor

Description

Add a test to ensure playlist_id is immutable and cannot be changed at the protocol level.

We have a similar test for track_id here.

How Has This Been Tested?

Test passes locally

@dharit-tan dharit-tan requested a review from isaacsolo June 5, 2024 21:31
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2024

⚠️ No Changeset found

Latest commit: 3da40ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dharit-tan dharit-tan enabled auto-merge (squash) June 5, 2024 21:45
@dharit-tan dharit-tan merged commit f6e2f33 into main Jun 5, 2024
12 checks passed
@dharit-tan dharit-tan deleted the rt-plid branch June 5, 2024 22:26
audius-infra pushed a commit that referenced this pull request Jun 6, 2024
Audius Protocol v0.6.120
42678bb 
[2933514] [PAY-3086] Add verified user rate limit (#8729) Raymond Jacobson
[f6e2f33] Add test to ensure updating playlist_id fails (#8736) Reed
[5343ba8] [C-4443][C-4444] Scheduled album releases (#8667) Reed
[4984706] [C-4463] POC add a 'skip check' param to /stream (#8709) JD Francis
schottra added a commit that referenced this pull request Jun 6, 2024
@schottra
Merge remote-tracking branch 'origin/main' into pay-2849-manager-mode…
c2949fd 
…-gated-content

* origin/main: (24 commits)
  [C-4467] Fix path reset on search (#8739)
  [C-4263] Add OptionsFilterButton and implement more search filters (#8737)
  [C-4660] POC: Pre-fetch CN stream urls (no /stream redirects) (#8741)
  on call: fix search on stage (#8743)
  Audius Protocol v0.6.120
  [PAY-2835] Add account switcher to oauth popup (#8716)
  [PAY-3086] Add verified user rate limit (#8729)
  [PAY-3085] Move payout wallet radio input to labeled (#8730)
  Add test to ensure updating playlist_id fails (#8736)
  [QA-1338] Fix headers for small screens (#8732)
  [C-4466] Update new search results page track preview number (#8735)
  [QA-865] Fix track mood alignment (#8731)
  [C-4443][C-4444] Scheduled album releases (#8667)
  [C-4361] Add grid and list layouts for new search track view (#8733)
  Fix lint (#8734)
  [C-4463] POC add a 'skip check' param to /stream (#8709)
  [QA-1306] Fix mobile text-link finalized state (#8720)
  [QA-1287] Fix multiple popovers on tracks table (#8721)
  [QA-1346] Fix select-page dropdown text alignment (#8722)
  [C-4360] Update SearchBarV2 to search on input (#8726)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacsolo isaacsolo isaacsolo approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dharit-tan @isaacsolo