Audit multisig #133
Merged
Audit multisig #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phraktle
previously approved these changes
Jul 27, 2018
eMarchenko
reviewed
Jul 27, 2018
| @@ -94,7 +94,8 @@ contract MultiSig { | |||
| script.state = ScriptState.Failed; | |||
There was a problem hiding this comment.
You don't need to mark script as failed prior to executing it, because you 100% have enough gas to set correct script.state after delegateCall. This will save gas and allow to clean up lines 97-102.
"problem" part of #10 is solved already, "code quality" isn't yet
There was a problem hiding this comment.
Good point, i'll remove the unnecessary parts.
…ow retain enough gas to set it properly after we have the result)
phraktle
approved these changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.10 and #.11 in MultiSig