-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot import LombScargle in extract_features.py #42
Comments
using hrv-analysis 1.0.4 |
I also had this issue, downgrading astropy to 5.3.4 caused it to import without the workaround. |
Thanks for your quick reply. Will do! |
No problem. Just a heads up, I'm not sure this library has been maintained for several years. The TINN feature isn't even implemented and I had to write it myself when trying to use the library. The interpolate NaN function doesn't handle leading NaN values. I calculated several features using the library and it also didn't really match with what I would expect the values to be based on the literature about HRV features and also didn't match my test set calculated from professional grade software. I'm looking into other solutions now, I found another Python library called pyHRV but it also hasn't been maintained in over 2 years and the tracked issues suggest their calculations for some values may be incorrect as well. Currently trying to figure out how to move forward. |
@pattersonltApp Any success in finding a good alternative which is maintained? |
For everyone interested, I have a pull request #40 that checks for the relevant version of AstroPy without needing to downgrade it. The maintenance status of the library seems unclear at the moment. |
Downgrading to 5.3.4 via Any other ideas? I don't know the maintenance status of HRVAnalysis. |
Hey @pattersonltApp did you find a good alternative HRV package? |
Hey all! The best solution I have been able to find is: If anyone else locates a better package please let me know (: |
Once trying to import the module in the script extract_features.py:
from astropy.stats import LombScargle
Get a message: module LombScargle not found.
So I found a workaround as the following:
try:
from astropy.timeseries import LombScargle
except ImportError:
from astropy.stats import LombScargle
Any possibility to implement this?
Thanks.
Francis
The text was updated successfully, but these errors were encountered: