added import check from astropy for LombScargle #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was just about to propose the same. Thanks @LucaCerina ! Hoping this gets merged soon. |
|
@robinchampseix what is the status of the project? Does it need helps in terms of maintenance? |
pattersonltApp
approved these changes
Mar 9, 2024
|
This works for me too! Thank you @LucaCerina |
LucaBia
approved these changes
Apr 24, 2024
|
I was about to say this. |
MatthewKrinn1
approved these changes
Jul 8, 2024
yuemingl
approved these changes
Aug 23, 2024
|
We need to merge this, anyone can help? @LucaCerina @Saskia-K @LucaBia @masud1901 |
|
hello everybody, I'm working on Aura projects and I was told there was an issue here. Sorry for the delay, I have submitted a pull request to fix it. Thanks a lot for the research, it helped a lot to investigate! I have open a Pull Request linked to this issue: #44. Of course feel free to comment on it. :) |
|
Closed as it is solved by #44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that Astropy 6.0.0 changed part of the API so now LombScargle periodogram fails to import (see https://docs.astropy.org/en/v6.0.0/changelog.html)
I've included an import check to be sure it doesn't crash.
I don't know if astropy 3.0.4 is a hard requirement, but if it's just for LombScargle it can be probably increased to the latest version.