Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix game starting SteamVR in replay and/or when switching FPFC #61

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Arimodu
Copy link

@Arimodu Arimodu commented Dec 18, 2023

Fix game automatically starting SteamVR when FPFC is switched on or off.
Done by checking if SteamVR is running before initializing OpenXR, if SteamVR is not running, dont initialize OpenXR. This way we even preserve the functionality for people who want to start the game in FPFC and then switch to SteamVR, since in that case user can just start SteamVR anytime along the way manually and it will be bound on next check

- Dont start OpenXR if SteamVR is not already running, makes FPFC replays not start SteamVR
@Arimodu Arimodu marked this pull request as draft December 19, 2023 01:29
@Arimodu
Copy link
Author

Arimodu commented Dec 19, 2023

Converting to a draft since not done yet. Aparently some people can fuck around and change the steam dir, so now I gotta write a finder

@Arimodu
Copy link
Author

Arimodu commented Dec 19, 2023

So I guess that fixes it, also gives the option to dynamically bind to SteamVR as long as fpfc flag is active, however thats kinda whacky so ¯_(ツ)_/¯

@Arimodu Arimodu marked this pull request as ready for review December 19, 2023 13:04
SiraUtil/SiraUtil.csproj Outdated Show resolved Hide resolved
SiraUtil/SiraUtil.csproj Outdated Show resolved Hide resolved
SiraUtil/Tools/FPFC/FPFCToggle.cs Outdated Show resolved Hide resolved
_siraLog.Debug(Environment.GetCommandLineArgs().Any(s => s.ToLower() == "oculus") ? "Running as vrmode Oculus" : "Running as vrmode Steam");
bool startXR = (IsProcessRunning("vrserver") && IsProcessRunning("vrcompositor")) || Environment.GetCommandLineArgs().Any(s => s.ToLower() == "oculus"); // If we're running Oculus, we need to start XR
if (startXR) InitializeXRLoader();
if (IsProcessRunning("vrserver") && IsProcessRunning("vrcompositor")) // Not sure how to check for Oculus if vrmode oculus is not working anymore
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realisticaly there is no need to reinitialize openxr, since the game can function fine in FPFC without it, but this makes it impossible for oculus only users to start the game in FPFC and still have the headset bind on toggle...

One way would be to see if there is an oculus specific process that could be checked, but I dont own an oculus headset anymore so I cant see if there is one

@Arimodu Arimodu requested a review from Auros January 21, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants