Remove localization-related things #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think you could keep the |
nicoco007
force-pushed
the
remove-localization
branch
from
c65d965
to
48dad93
Compare
|
Oops, that didn't even occur to me, you're totally right! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that the
RemoveLocalizationLogpatch is causingLocalizationImporter's static constructor to be called too early and prevents translation files registered by mods loaded after SiraUtil from being loaded properly. This PR removes it along with some other localization-related things that either now belong in SiraLocalizer itself or are no longer necessary.