Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note debris redecoration and version #72

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

whatdahopper
Copy link
Contributor

@whatdahopper whatdahopper commented Nov 10, 2024

This was mostly based on Lapiz's own implementation of note debris redecoration, as I was unable to get the normal transpiler working.

In my testing, it works 100% fine and I have zero issues with it.

@whatdahopper
Copy link
Contributor Author

whatdahopper commented Nov 10, 2024

Another issue is that because the NoteDebrisPoolInstaller is a ScriptableObject, it persists, so we can't just set our modifications without restoring it after, unfortunately I don't think transpilers would be suitable regardless.

Let me know what you think though, if applicable.

UPDATE: See comment below.

@whatdahopper
Copy link
Contributor Author

UPDATE: I have gotten the transpiler to work, there should be no regressions (hopefully). I was also wrong about the modifications stuff, since the transpiler modifies the instructions directly, avoiding modifying the scriptable object fields.

@nicoco007 nicoco007 merged commit dd6538c into Auros:main Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants