Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Samp add server by domain #593

Merged
merged 11 commits into from
Feb 18, 2022
Merged

Fix Samp add server by domain #593

merged 11 commits into from
Feb 18, 2022

Conversation

bumbummen99
Copy link
Collaborator

@bumbummen99 bumbummen99 commented Feb 12, 2022

Related #588

We do fail at the following line:

$this->server_code = implode('', array_map('chr', explode('.', $server->ip()))) .

It simply does expect an IP and not a domain

@bumbummen99
Copy link
Collaborator Author

bumbummen99 commented Feb 12, 2022

It should resolve to IP over here the input to the method being the host key of the server definition:

protected function checkAndSetIpPort($ip_address)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 87.778% when pulling 9795f02 on bumbummen99:patch-4 into af6641c on Austinb:v3.

@coveralls
Copy link

coveralls commented Feb 12, 2022

Coverage Status

Coverage increased (+6.4%) to 94.235% when pulling fea5543 on bumbummen99:patch-4 into af6641c on Austinb:v3.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 87.778% when pulling 9795f02 on bumbummen99:patch-4 into af6641c on Austinb:v3.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@bumbummen99
Copy link
Collaborator Author

bumbummen99 commented Feb 13, 2022

@Austinb Done. This is not a breaking change tho i would suggest a minor version since this will change the host and join url in the result to now, correctly, be the IP as it was originally intended in GameQ\Server.php.

@Austinb Austinb merged commit 71634b3 into Austinb:v3 Feb 18, 2022
@bumbummen99 bumbummen99 added the Bug This request does fix a bug. label Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This request does fix a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants