Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pterodactyl Games #655

Merged
merged 5 commits into from
Aug 28, 2022
Merged

Conversation

Erani0
Copy link
Contributor

@Erani0 Erani0 commented Aug 27, 2022

Add Barotrauma
Add Black Mesa
Add Citadel Forged with fire
Add Half Life
Add Fistful of Frags
Add Modiverse
Add No More Room in Hell
Add Open Fortress
Add Stormworks Build and Rescue
Add Sven Co-op

@bumbummen99
Copy link
Collaborator

Can you sign the commit with git commit --amend --signoff -S please?

@bumbummen99 bumbummen99 added the Enhancement This request does add something to the project. label Aug 28, 2022
@Erani0 Erani0 force-pushed the Add-Pterodactyl-supported-Games branch from 49bab63 to b3d6f98 Compare August 28, 2022 13:52
Add Barotrauma
Add Black Mesa
Add Citadel Forged with fire
Add Half Life
Add Fistful of Frags
Add Modiverse
Add No More Room in Hell
Add Open Fortress
Add Stormworks Build and Rescue
Add Sven Co-op

Signed-off-by: Eranio <info@eranio.de>
@Erani0 Erani0 force-pushed the Add-Pterodactyl-supported-Games branch from b3d6f98 to bf761d9 Compare August 28, 2022 13:53
Copy link
Collaborator

@bumbummen99 bumbummen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the review comments, some tests also look strange

src/GameQ/Protocols/Blackmesa.php Outdated Show resolved Hide resolved
src/GameQ/Protocols/Citadel.php Outdated Show resolved Hide resolved
tests/Protocols/Barotrauma.php Outdated Show resolved Hide resolved
tests/Protocols/Blackmesa.php Outdated Show resolved Hide resolved
tests/Protocols/Citadel.php Outdated Show resolved Hide resolved
tests/Protocols/Modiverse.php Outdated Show resolved Hide resolved
tests/Protocols/Nmrih.php Outdated Show resolved Hide resolved
tests/Protocols/Of.php Outdated Show resolved Hide resolved
tests/Protocols/Sco.php Outdated Show resolved Hide resolved
tests/Protocols/Stormworks.php Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Aug 28, 2022

Coverage Status

Coverage decreased (-0.4%) to 88.146% when pulling a9618a4 on Erani0:Add-Pterodactyl-supported-Games into 4f4b153 on Austinb:v3.

@Erani0
Copy link
Contributor Author

Erani0 commented Aug 28, 2022

the testfile from Add No More Room in Hell not correct

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

Copy link
Collaborator

@bumbummen99 bumbummen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bumbummen99 bumbummen99 merged commit 44e7906 into Austinb:v3 Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This request does add something to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants